Uh oh!
There was an error while loading. Please reload this page.
Add specification for isdtype - #503
Conversation
kgryte
commented
Nov 3, 2022
Based on the 3 November 2022 meeting, a few changes should be made to this PR:
|
Uh oh!
There was an error while loading. Please reload this page.
rgommers
commented
Nov 17, 2022
(1) and (4) are more clear cut than (2) and (3), which make things more verbose. But I'm fine with all four of those. I do really want to see the name change to either |
kgryte
commented
Nov 21, 2022
I've updated the PR to incorporate the proposed changes 1-4, and I've renamed the API to This PR should be ready for another round of review. |
This PR
dtypeis of a specified data type kind.specifies that the function name isUpdate: based on feedback, the function name is specified asis_type(rather thanis_dtype) in order to matchresult_type. Another possibility isistypein order to matchastype.isdtype. The functionsastypeandresult_typeare now considered ill-named (e.g.,as_dtype/asdtypeandresult_dtype/common_dtypeare considered better based on present naming conventions, but are named as such due to historical reasons). The choice ofisdtypeis considered preferable overis_dtypein order to be consistent withisfinite,isinf, andisnan, which already exist in the specification. One should note that this does not follow strict PEP8 guidance; however, consistency within specification was considered preferable over PEP8 purity.dtype, astr, and atupleofdtypeandstr.'bool','signed integer','unsigned integer','integral','real floating','complex floating', and'numeric'."floating"(as described in the specification data type categories). This kind would be achieved via a tuple:('real floating', 'complex floating').