Uh oh!
There was an error while loading. Please reload this page.
Update guidance concerning mixing arrays with Python scalars to handle complex - #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
booland real-valued data types. This PR updates the guidance to accommodate mixing acomplexPython scalar with arrays. Guidance is intentionally limited to when a scalar iscomplexand an array has a complex floating-point array data type.complexand an array has a real-valued array data type. Behavior is left implementation-specific (e.g., promotion, exception, etc). Given that current guidance requires converting a scalar to the array data type, to accommodatecomplexscalars and real-valued arrays, we'd need to specify casting rules forcomplexto real, which is something the specification has thus far avoided (e.g.,astype,real,imag,conj, et al). This PR aims to be consistent with those prior decisions.