Skip to content

Add complex support to asinh - #522

Merged
rgommers merged 2 commits into
mainfrom
cmplx-asinh
Dec 5, 2022
Merged

Add complex support to asinh#522
rgommers merged 2 commits into
mainfrom
cmplx-asinh

Conversation

@kgryte

@kgrytekgryte commented Nov 27, 2022

Copy link
Copy Markdown
Contributor

This PR

  • adds complex number support to asinh by documenting special cases. By convention, the inverse hyperbolic sine has a branch cut placed at the line segments (-infinity j, -j) and (j, infinity j) of the imaginary axis.
  • updates the input and output array data types to be any floating-point data type, not just real-valued floating-point data types.
  • derives special cases from C99

@kgrytekgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels Nov 27, 2022
@kgrytekgryte added this to the v2022 milestone Nov 27, 2022
@kgrytekgryte mentioned this pull request Nov 27, 2022
Closed
rgommers
rgommers approved these changes Dec 5, 2022
View reviewed changes

@rgommersrgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte

@rgommers
rgommers merged commit c1fbd4d into mainDec 5, 2022
@rgommers
rgommers deleted the cmplx-asinh branch December 5, 2022 16:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommersrgommersrgommers approved these changes

Assignees

No one assigned

Labels

API changeChanges to existing functions or objects in the API.topic: Complex Data TypesComplex number data types.

Projects

None yet

Milestone

v2022

Development

Successfully merging this pull request may close these issues.

2 participants

@kgryte@rgommers