Skip to content

Add complex number support to atan - #523

Merged
rgommers merged 1 commit into
mainfrom
cmplx-atan
Dec 5, 2022
Merged

Add complex number support to atan#523
rgommers merged 1 commit into
mainfrom
cmplx-atan

Conversation

@kgryte

Copy link
Copy Markdown
Contributor

This PR

  • adds complex number support to atan by documenting special cases. By convention, the inverse tangent has a branch cut placed at the line segments (-infinity j, -j) and (j, infinity j) of the imaginary axis.
  • updates the input and output array data types to be any floating-point data type, not just real-valued floating-point data types.
  • derives special cases from C99

@kgrytekgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels Nov 27, 2022
@kgrytekgryte added this to the v2022 milestone Nov 27, 2022

@rgommersrgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte. This PR has been open for a week and the complex number basic principles (branch cuts, type promotion, etc.) have been reviewed in separate PRs already. So I'll merge this.

@rgommers
rgommers merged commit 57d60ce into mainDec 5, 2022
@rgommers
rgommers deleted the cmplx-atan branch December 5, 2022 16:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API changeChanges to existing functions or objects in the API.topic: Complex Data TypesComplex number data types.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kgryte@rgommers