Skip to content

Add complex number support to log1p - #534

Merged
rgommers merged 1 commit into
mainfrom
cmplx-log1p
Dec 12, 2022
Merged

Add complex number support to log1p#534
rgommers merged 1 commit into
mainfrom
cmplx-log1p

Conversation

@kgryte

@kgrytekgryte commented Dec 1, 2022

Copy link
Copy Markdown
Contributor

This PR

  • adds complex number support to log1p by documenting special cases. By convention, the natural logarithm has a single branch cut, which is defined as the real interval (-infinity, 0).
  • updates the input and output array data types to be any floating-point data type, not just real-valued floating-point data types.
  • derives special cases from those described in Add complex number support to log #514.

@kgrytekgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels Dec 1, 2022
@kgrytekgryte added this to the v2022 milestone Dec 1, 2022
@kgrytekgryte mentioned this pull request Dec 1, 2022
Closed
rgommers
rgommers approved these changes Dec 12, 2022
View reviewed changes

@rgommersrgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks @kgryte

@rgommers
rgommers merged commit 31142bb into mainDec 12, 2022
@rgommers
rgommers deleted the cmplx-log1p branch December 12, 2022 19:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommersrgommersrgommers approved these changes

Assignees

No one assigned

Labels

API changeChanges to existing functions or objects in the API.topic: Complex Data TypesComplex number data types.

Projects

None yet

Milestone

v2022

Development

Successfully merging this pull request may close these issues.

2 participants

@kgryte@rgommers