Skip to content

Add complex number support to linalg.det - #542

Merged
rgommers merged 1 commit into
mainfrom
cmplx-linalg-det
Dec 13, 2022
Merged

Add complex number support to linalg.det#542
rgommers merged 1 commit into
mainfrom
cmplx-linalg-det

Conversation

@kgryte

Copy link
Copy Markdown
Contributor

This PR

  • adds support for complex numbers to linalg.det.
  • updates the input and output array data types to be any floating-point data type, not just real-valued floating-point data types. In certain circumstances, the determinant of a complex matrix can be real-valued; however, this is not generally true. In which case, the guidance remains that the output data type be required to have the same data type as the input array x.

@kgrytekgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra. labels Dec 1, 2022
@kgrytekgryte added this to the v2022 milestone Dec 1, 2022

@rgommersrgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte

@rgommers
rgommers merged commit 3f1b467 into mainDec 13, 2022
@rgommers
rgommers deleted the cmplx-linalg-det branch December 13, 2022 21:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API changeChanges to existing functions or objects in the API.topic: Complex Data TypesComplex number data types.topic: Linear AlgebraLinear algebra.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kgryte@rgommers