Skip to content

Add complex number support to square - #552

Merged
rgommers merged 1 commit into
mainfrom
cmplx-square
Dec 14, 2022
Merged

Add complex number support to square#552
rgommers merged 1 commit into
mainfrom
cmplx-square

Conversation

@kgryte

@kgrytekgryte commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

This PR

  • adds complex number support to square. As square is shorthand for multiply(x, x), special cases should match that of multiply for both real- and complex-valued floating-point operands.
  • updates the input and output array data types to be any numeric data type, not just real-valued data types.
  • depends on Add complex number support for multiplication #551.

@kgrytekgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels Dec 5, 2022
@kgrytekgryte added this to the v2022 milestone Dec 5, 2022
@kgrytekgryte mentioned this pull request Dec 12, 2022
Closed
rgommers
rgommers approved these changes Dec 14, 2022
View reviewed changes

@rgommersrgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR this depended on is merged now, and this LGTM - so in it goes. Thanks @kgryte

@rgommers
rgommers merged commit 5a68453 into mainDec 14, 2022
@rgommers
rgommers deleted the cmplx-square branch December 14, 2022 19:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommersrgommersrgommers approved these changes

Assignees

No one assigned

Labels

API changeChanges to existing functions or objects in the API.topic: Complex Data TypesComplex number data types.

Projects

None yet

Milestone

v2022

Development

Successfully merging this pull request may close these issues.

2 participants

@kgryte@rgommers