Skip to content

Add complex number support to prod - #553

Merged
rgommers merged 1 commit into
mainfrom
cmplx-prod
Dec 14, 2022
Merged

Add complex number support to prod#553
rgommers merged 1 commit into
mainfrom
cmplx-prod

Conversation

@kgryte

Copy link
Copy Markdown
Contributor

This PR

  • adds support for computing the product of complex numbers. As described in Add complex number support for multiplication #551, for complex numbers having finite components, complex number multiplication is well-defined; however, special cases involving NaN and infinite components may diverge depending on how one chooses to model complex infinity.
  • specifies that special cases be derived as if the operation was implemented as a reduction over multiply.
  • requires that, if x is a complex floating-point data type and dtype is None, the function must return an array having the default complex floating-point data type.
  • updates the input and output array data types to be any numeric data type, not just real-valued data types.
  • depends on Add complex number support for multiplication #551.

@kgrytekgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels Dec 5, 2022
@kgrytekgryte added this to the v2022 milestone Dec 5, 2022

@rgommersrgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR this depended on is merged now, and this LGTM - so in it goes. Thanks @kgryte

@rgommers
rgommers merged commit 91656a7 into mainDec 14, 2022
@rgommers
rgommers deleted the cmplx-prod branch December 14, 2022 19:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API changeChanges to existing functions or objects in the API.topic: Complex Data TypesComplex number data types.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kgryte@rgommers