Skip to content

Add complex number support to linalg.cross - #559

Merged
rgommers merged 1 commit into
mainfrom
cmplx-cross
Dec 14, 2022
Merged

Add complex number support to linalg.cross#559
rgommers merged 1 commit into
mainfrom
cmplx-cross

Conversation

@kgryte

@kgrytekgryte commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

This PR

  • adds complex number support to linalg.cross. No special considerations are required to accommodate complex numbers.
  • updates the input and output array data types to be any numeric data type, not just real-valued data types.
  • updates guidance to require a numeric data type. Previously, it said "should", but this was likely an oversight, as computing the cross product for non-numeric data types does not make sense.

@kgrytekgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra. labels Dec 12, 2022
@kgrytekgryte added this to the v2022 milestone Dec 12, 2022
@kgrytekgryte mentioned this pull request Dec 12, 2022
Closed
rgommers
rgommers approved these changes Dec 14, 2022
View reviewed changes

@rgommersrgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte

@rgommers
rgommers merged commit e9a1683 into mainDec 14, 2022
@rgommers
rgommers deleted the cmplx-cross branch December 14, 2022 19:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommersrgommersrgommers approved these changes

Assignees

No one assigned

Labels

API changeChanges to existing functions or objects in the API.topic: Complex Data TypesComplex number data types.topic: Linear AlgebraLinear algebra.

Projects

None yet

Milestone

v2022

Development

Successfully merging this pull request may close these issues.

2 participants

@kgryte@rgommers