Skip to content

Add complex number support to linalg.outer - #560

Merged
rgommers merged 1 commit into
mainfrom
cmplx-linalg-outer
Dec 14, 2022
Merged

Add complex number support to linalg.outer#560
rgommers merged 1 commit into
mainfrom
cmplx-linalg-outer

Conversation

@kgryte

Copy link
Copy Markdown
Contributor

This PR

  • adds complex number support to linalg.outer. No special considerations are required to accommodate complex numbers.
  • updates the input and output array data types to be any numeric data type, not just real-valued data types.
  • updates guidance to require a numeric data type. If left as "should", would imply that non-numeric data types would be permitted if a library had overriding reasons for doing so. However, for computing the outer product, non-numeric data types are not applicable.

@kgrytekgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra. labels Dec 12, 2022
@kgrytekgryte added this to the v2022 milestone Dec 12, 2022

@rgommersrgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is as straightforward as it can get - in it goes

@rgommers
rgommers merged commit 8cf015e into mainDec 14, 2022
@rgommers
rgommers deleted the cmplx-linalg-outer branch December 14, 2022 19:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API changeChanges to existing functions or objects in the API.topic: Complex Data TypesComplex number data types.topic: Linear AlgebraLinear algebra.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kgryte@rgommers