Skip to content

Add complex number support to linalg.pinv - #564

Merged
rgommers merged 2 commits into
mainfrom
cmplx-pinv
Dec 14, 2022
Merged

Add complex number support to linalg.pinv#564
rgommers merged 2 commits into
mainfrom
cmplx-pinv

Conversation

@kgryte

Copy link
Copy Markdown
Contributor

This PR

  • adds complex number support to linalg.pinv.
  • updates the allowed input data type from real-valued floating-point to any floating-point data type.
  • makes explicit that, for matrix stacks, the pseudo-inverse must be computed for each matrix in the stack.
  • adds an extended description helping contextualize the use rtol.
  • (in practice) depends on Add complex number support to linalg.svd #561.

@kgrytekgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra. labels Dec 12, 2022
@kgrytekgryte added this to the v2022 milestone Dec 12, 2022

@rgommersrgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks @kgryte

@rgommers
rgommers merged commit 7d9752f into mainDec 14, 2022
@rgommers
rgommers deleted the cmplx-pinv branch December 14, 2022 20:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API changeChanges to existing functions or objects in the API.topic: Complex Data TypesComplex number data types.topic: Linear AlgebraLinear algebra.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kgryte@rgommers