Skip to content

Add complex number support to linalg.matrix_norm - #565

Merged
rgommers merged 1 commit into
mainfrom
cmplx-linalg-matrix-norm
Dec 14, 2022
Merged

Add complex number support to linalg.matrix_norm#565
rgommers merged 1 commit into
mainfrom
cmplx-linalg-matrix-norm

Conversation

@kgryte

Copy link
Copy Markdown
Contributor

This PR

  • adds complex number support to linalg.matrix_norm. The main substantive change is updating the input and output data types. For both real- and complex-valued inputs, matrix norms involve computing absolute values or singular values, so no changes are necessary in norm definitions to accommodate complex numbers.
  • requires that the output data type always be a real-valued floating-point data type.
  • depends on Add complex number support to linalg.svd #561.

@kgrytekgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra. labels Dec 12, 2022
@kgrytekgryte added this to the v2022 milestone Dec 12, 2022

@rgommersrgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte

@rgommers
rgommers merged commit 32de395 into mainDec 14, 2022
@rgommers
rgommers deleted the cmplx-linalg-matrix-norm branch December 14, 2022 19:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API changeChanges to existing functions or objects in the API.topic: Complex Data TypesComplex number data types.topic: Linear AlgebraLinear algebra.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kgryte@rgommers