Skip to content

Add complex number support to linalg.solve - #566

Merged
rgommers merged 2 commits into
mainfrom
cmplx-linalg-solve
Dec 14, 2022
Merged

Add complex number support to linalg.solve#566
rgommers merged 2 commits into
mainfrom
cmplx-linalg-solve

Conversation

@kgryte

@kgrytekgryte commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

This PR

  • adds complex number support to linalg.solve.
  • updates the allowed data types from real-valued floating-point to any floating-point data type.
  • adds an extended description describing the operation.
  • makes explicit that, for matrix stacks, a solution must be computed for each matrix in the stack.

@kgrytekgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra. labels Dec 12, 2022
@kgrytekgryte added this to the v2022 milestone Dec 12, 2022
@kgrytekgryte mentioned this pull request Dec 13, 2022
Closed
rgommers
rgommers approved these changes Dec 14, 2022
View reviewed changes

@rgommersrgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added math explanations and their rendered version LGTM. In it goes, thanks @kgryte

@rgommers
rgommers merged commit 35baedc into mainDec 14, 2022
@rgommers
rgommers deleted the cmplx-linalg-solve branch December 14, 2022 19:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommersrgommersrgommers approved these changes

Assignees

No one assigned

Labels

API changeChanges to existing functions or objects in the API.topic: Complex Data TypesComplex number data types.topic: Linear AlgebraLinear algebra.

Projects

None yet

Milestone

v2022

Development

Successfully merging this pull request may close these issues.

2 participants

@kgryte@rgommers