Uh oh!
There was an error while loading. Please reload this page.
Add versioning support to DLPack APIs - #602
Conversation
Uh oh!
There was an error while loading. Please reload this page.
kgryte
commented
Apr 17, 2023
@rgommers Currently, this PR adds a I suppose, in theory, could also add a In the sample code (ref: https://github.com/data-apis/array-api/pull/602/files#diff-546629919d7440647da1b89638a960e831bfa6e855e662983976d48643ec3022R368), you indicate that it's on the consumer to accommodate the producer, which seems reasonable if the goal is to reduce the burden for producers by limiting the number of versions to support. But then you also state in https://github.com/data-apis/array-api/pull/602/files#diff-546629919d7440647da1b89638a960e831bfa6e855e662983976d48643ec3022R362 that, when the |
rgommers
commented
Apr 17, 2023
It doesn't really. It indicates nothing beyond what the max version is, with the intended effect being "if the producer supports a version
What does knowing the minimum version change? I think nothing, either way it's either okay or the user gets an error.
It doesn't, the consumer is free to raise an exception if it has dropped support for some old version. |
kgryte
commented
Apr 18, 2023
@leofang I see that you self-requested a review. You have any further thoughts on this PR? |
Uh oh!
There was an error while loading. Please reload this page.
leofang
left a comment
There was a problem hiding this comment.
Sorry for late response, Ralf! Left a few questions.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
leofang
commented
Jan 15, 2024
@rgommers do you have time to address the review, or should I take over this PR? |
Uh oh!
There was an error while loading. Please reload this page.
rgommers
commented
Jan 16, 2024
If you'd be able to take over @leofang, that would help I think. I'm not fully up to speed on what happened with the removed |
kgryte
commented
Feb 7, 2024
@leofang Would you like me to go ahead and resolve the merge conflicts on this PR, so that you can just focus on making the updates? |
leofang
commented
Feb 7, 2024
If you have time, yes please, but otherwise no worries I'll get to it tonight or tomorrow 😓 |
leofang
commented
Feb 7, 2024
@tqchen@seberg@rgommers@oleksandr-pavlyk Could you review the change here? We're finalizing the v2023 standard. Thanks! 🙂 |
seberg
left a comment
There was a problem hiding this comment.
Thanks Ralf! LGTM, one small suggestion.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
rgommers
commented
Feb 8, 2024
Thanks for the updates! This looks ready to merge to me. |
leofang
commented
Feb 9, 2024
Thanks all, let's merge and refine if needed, then. |
xref dmlc/dlpack#116