Uh oh!
There was an error while loading. Please reload this page.
Backport type fixes to __getitem__ to previous specification revisions - #687
Merged
Merged
Conversation
kgryte
commented
Oct 18, 2023
ContributorAuthor
@honno Would you mind reviewing? |
kgryte
commented
Nov 6, 2023
ContributorAuthor
As this has gotten the thumbs up, will go ahead and merge. Any further changes can be addressed in follow-up PRs... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Nonein multi-axis indexing from the 2021 revision onward, the exclusion ofNonefrom the typings was an omission. This PR addresses this omission.newaxiswhich is not mentioned in the indexing document, but should likely be mentioned due to its use as a more literate means for introducing new axes.