Uh oh!
There was an error while loading. Please reload this page.
Revise guidance to require a minimum upper bound for supported ranks - #702
Merged
Conversation
kgryte
commented
Nov 6, 2023
ContributorAuthor
17 tasks
Zac-HD
commented
Nov 6, 2023
If array libraries have a consistent way to retrieve the maximum dimensionality they support, Hypothesis can provide more informative error messages. iirc Numpy has a MAX_DIMS constant somewhere... |
kgryte
commented
Nov 6, 2023
ContributorAuthor
rgommers
commented
Nov 16, 2023
Member
This is pretty straightforward. I'll aim to merge this in a few days unless an objection appears. |
leofang
approved these changes
Nov 16, 2023
kgryte
commented
Nov 30, 2023
ContributorAuthor
As this PR has received multiple approvals and no objections, will go ahead and merge. Any further changes can be addressed in follow-up PRs... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
4. Additionally, array libraries will be required to explicitly document their maximum supported rank.Related