Release the NB gc timer when an incoming socket closes - #70
Merged
Conversation
enhance() starts a 10s interval to time out stalled transfers and only unref()s it. unref keeps the timer from holding the process open, but the Timeout stays in Node's timer list - a GC root - so the interval's closure pinned nb, sched, opts and the socket itself, with all its eventCallbacks and the dead net.Socket. Every WebSocket a server ever accepted stayed in the heap. Measured against a real ToolSocket server, incoming sockets that connect, subscribe and close: 19,035 B retained per connection at N=200 and 17,417 B at N=600 - linear in connection count. With the close handler: 1,862 B and 237 B, and the total falls from 372 KB to 142 KB between those runs, i.e. no longer proportional to N. Guarded exactly like the pressure-registry entry above it: an auto-reconnecting outgoing socket keeps its timer across reconnects, while an incoming socket (url === null) can never reopen and releases it. large_object_space and external deltas were zero throughout - this is plain old-space retention.
hobinjk-dts
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enhance() starts a 10s interval to time out stalled transfers and only unref()s it. unref keeps the timer from holding the process open, but the Timeout stays in Node's timer list - a GC root - so the interval's closure pinned nb, sched, opts and the socket itself, with all its eventCallbacks and the dead net.Socket. Every WebSocket a server ever accepted stayed in the heap.
Measured against a real ToolSocket server, incoming sockets that connect, subscribe and close: 19,035 B retained per connection at N=200 and 17,417 B at N=600 - linear in connection count. With the close handler: 1,862 B and 237 B, and the total falls from 372 KB to 142 KB between those runs, i.e. no longer proportional to N.
Guarded exactly like the pressure-registry entry above it: an auto-reconnecting outgoing socket keeps its timer across reconnects, while an incoming socket (url === null) can never reopen and releases it. large_object_space and external deltas were zero throughout - this is plain old-space retention.