Skip to content

revert: relocate typegen cache to committed .appkit/ dir - #509

Merged
MarioCadenas merged 1 commit into
mainfrom
revert-502-move-typegen
Aug 3, 2026
Merged

revert: relocate typegen cache to committed .appkit/ dir#509
MarioCadenas merged 1 commit into
mainfrom
revert-502-move-typegen

Conversation

@MarioCadenas

Copy link
Copy Markdown
Collaborator

Reverts #502

@MarioCadenas
MarioCadenas requested a review from a team as a code ownerAugust 3, 2026 13:49
@MarioCadenasMarioCadenas changed the title Revert "feat(appkit): relocate typegen cache to committed .appkit/ dir"revert: relocate typegen cache to committed .appkit/ dirAug 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📦 Bundle size report

Compared against bundle-size-baseline.json (main).

@databricks/appkit

npm tarball (packed): 797 KB (+34 KB) — gzipped download (dist + bin; excludes release-only docs/NOTICE).

distrawgzip
JS (runtime)820 KB (+29 KB)286 KB (+9.9 KB)
Type declarations302 KB (+17 KB)103 KB (+5.9 KB)
Source maps1.6 MB (+65 KB)536 KB (+21 KB)
Other11 KB3.7 KB
Total2.7 MB (+110 KB)929 KB (+37 KB)
Per-entry composition (own code — deps external (as shipped))
EntryInitial (gz)Lazy (gz)Total (gz)node_modules (min)Own code (min)
.86 KB (+10 B)2.5 KB89 KB (+10 B)external281 KB (+42 B)
./beta44 KB (+4.6 KB)429 B (+198 B)45 KB (+4.8 KB)external129 KB (+9.5 KB)
./type-generator19 KB0 B19 KBexternal54 KB

Chunks:

EntryChunkLoadSize (gz)
.index.jsinitial82 KB
.utils.jsinitial4.0 KB
.remote-tunnel-manager.jslazy2.5 KB
./betabeta.jsinitial29 KB
./betastream-manager.jsinitial5.8 KB
./betawide-event-emitter.jsinitial3.2 KB
./betadatabricks.jsinitial3.0 KB
./betaconfiguration.jsinitial2.1 KB
./betaservice-context.jsinitial1.3 KB
./betaclient-options.jsinitial220 B
./betasupervisor-api.jslazy184 B
./betadatabricks.jslazy132 B
./betaindex.jslazy113 B
./type-generatorindex.jsinitial19 KB

@databricks/appkit-ui

npm tarball (packed): 305 KB (+101 B) — gzipped download (dist + bin; excludes release-only docs/NOTICE).

distrawgzip
JS (runtime)360 KB (+390 B)119 KB (+60 B)
Type declarations205 KB74 KB
Source maps686 KB (+390 B)224 KB (+66 B)
CSS16 KB3.3 KB
Total1.2 MB (+780 B)422 KB (+126 B)
Per-entry composition (consumer bundle — deps bundled, peerDeps external)
EntryInitial (gz)Lazy (gz)Total (gz)node_modules (min)Own code (min)
./js4.3 KB49 KB54 KB208 KB12 KB
./js/beta20 B0 B20 B0 B0 B
./react429 KB (+55 B)49 KB478 KB (+55 B)1.3 MB168 KB (+390 B)
./react/beta20 B0 B20 B0 B0 B

Chunks:

EntryChunkLoadSize (gz)
./jsindex.jsinitial4.2 KB
./jschunkinitial120 B
./jsapache-arrowlazy49 KB
./js/betabeta.jsinitial20 B
./reactindex.jsinitial427 KB
./reacttslibinitial2.1 KB
./reactapache-arrowlazy49 KB
./react/betabeta.jsinitial20 B

@MarioCadenas
MarioCadenas enabled auto-merge (squash) August 3, 2026 13:53
@github-actions

Copy link
Copy Markdown
Contributor

🤖 AppKit PR bot

🔬 Run evals

Start an eval for this PR from the evals-monitor app: Go to Evals Monitor →

📦 Try this PR's app template

Scaffolds a new app from this PR's SDK build. Run it in any folder (requires the GitHub CLI — gh auth login — and the Databricks CLI):

gh run download 30819766101 -R databricks/appkit -n appkit-template-0.48.0-pr.9601c6f-revert-502-move-typegen-509 -D appkit-pr-509 \
&& unzip -o "appkit-pr-509/appkit-template-0.48.0-pr.9601c6f-revert-502-move-typegen-509.zip" -d "appkit-pr-509" \
&& databricks apps init --template "appkit-pr-509"

The template pins @databricks/appkit and @databricks/appkit-ui to tarballs built from this branch, so the scaffolded app runs against this PR's code.

@MarioCadenas
MarioCadenas merged commit 9497431 into mainAug 3, 2026
11 of 12 checks passed
@MarioCadenas
MarioCadenas deleted the revert-502-move-typegen branch August 3, 2026 13:57
atilafassina added a commit that referenced this pull request Aug 4, 2026
Brings in main's revert of PR #502 (#509), which relocated the typegen
cache back to node_modules/.databricks. This branch was cut from the
#502 merge commit and inherited that surface without ever depending on
it, so the sync is a clean subtraction: cache-paths.ts, the committed
apps/dev-playground/.appkit/ fixtures, the cache-serialization tests,
and the warehouse-less-deploy docs all drop out, while the metric-view
runtime (useMetricView, formatters, metric-views.ts codegen) is
untouched.
bundle-size-baseline.json conflicted because both sides regenerated it;
resolved by taking main's, to be regenerated against the merged tree.
Co-authored-by: Isaac
Signed-off-by: Atila Fassina <atila@fassina.eu>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@MarioCadenas@atilafassina