Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 22
feat: add typed sql parameter helpers#9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a87ec1f
feat: add typed sql parameter helpers
ditadi 53bacdd
refactor: add SQLType to analytics params
ditadi 1facc75
refactor: remove routeTree.gen.ts from playground from format
ditadi 7d33775
refactor: sql helpers being exported only by app-kit and app-kit-ui/js
ditadi 8643813
fix: shared import path
ditadi 28af821
feat: add binary type on sql helpers
ditadi 93fd67d
test: add binary encoding compatibility test for Databricks format
ditadi 919113f
feat: sql.binary() returns STRING with hex encoding and add interacti…
ditadi 8f535ce
Merge branch 'main' into feat/sql-param-helpers
fjakobs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3 apps/dev-playground/client/src/components/analytics/usage-trends-chart.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -8,125 +8,150 @@ | ||
| // You should NOT make any changes in this file as it will be overwritten. | ||
| // Additionally, you should also exclude this file from your linter and/or formatter to prevent it from being checked or modified. | ||
| import { Route as rootRouteImport } from "./routes/__root"; | ||
ditadi marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| import { Route as TelemetryRouteRouteImport } from "./routes/telemetry.route"; | ||
| import { Route as ReconnectRouteRouteImport } from "./routes/reconnect.route"; | ||
| import { Route as DataVisualizationRouteRouteImport } from "./routes/data-visualization.route"; | ||
| import { Route as AnalyticsRouteRouteImport } from "./routes/analytics.route"; | ||
| import { Route as IndexRouteImport } from "./routes/index"; | ||
| import { Route as rootRouteImport } from './routes/__root' | ||
| import { Route as TelemetryRouteRouteImport } from './routes/telemetry.route' | ||
| import { Route as SqlHelpersRouteRouteImport } from './routes/sql-helpers.route' | ||
| import { Route as ReconnectRouteRouteImport } from './routes/reconnect.route' | ||
| import { Route as DataVisualizationRouteRouteImport } from './routes/data-visualization.route' | ||
| import { Route as AnalyticsRouteRouteImport } from './routes/analytics.route' | ||
| import { Route as IndexRouteImport } from './routes/index' | ||
| const TelemetryRouteRoute = TelemetryRouteRouteImport.update({ | ||
| id: "/telemetry", | ||
| path: "/telemetry", | ||
| id: '/telemetry', | ||
| path: '/telemetry', | ||
| getParentRoute: () => rootRouteImport, | ||
| } as any); | ||
| } as any) | ||
| const SqlHelpersRouteRoute = SqlHelpersRouteRouteImport.update({ | ||
| id: '/sql-helpers', | ||
| path: '/sql-helpers', | ||
| getParentRoute: () => rootRouteImport, | ||
| } as any) | ||
| const ReconnectRouteRoute = ReconnectRouteRouteImport.update({ | ||
| id: "/reconnect", | ||
| path: "/reconnect", | ||
| id: '/reconnect', | ||
| path: '/reconnect', | ||
| getParentRoute: () => rootRouteImport, | ||
| } as any); | ||
| } as any) | ||
| const DataVisualizationRouteRoute = DataVisualizationRouteRouteImport.update({ | ||
| id: "/data-visualization", | ||
| path: "/data-visualization", | ||
| id: '/data-visualization', | ||
| path: '/data-visualization', | ||
| getParentRoute: () => rootRouteImport, | ||
| } as any); | ||
| } as any) | ||
| const AnalyticsRouteRoute = AnalyticsRouteRouteImport.update({ | ||
| id: "/analytics", | ||
| path: "/analytics", | ||
| id: '/analytics', | ||
| path: '/analytics', | ||
| getParentRoute: () => rootRouteImport, | ||
| } as any); | ||
| } as any) | ||
| const IndexRoute = IndexRouteImport.update({ | ||
| id: "/", | ||
| path: "/", | ||
| id: '/', | ||
| path: '/', | ||
| getParentRoute: () => rootRouteImport, | ||
| } as any); | ||
| } as any) | ||
| export interface FileRoutesByFullPath { | ||
| "/": typeof IndexRoute; | ||
| "/analytics": typeof AnalyticsRouteRoute; | ||
| "/data-visualization": typeof DataVisualizationRouteRoute; | ||
| "/reconnect": typeof ReconnectRouteRoute; | ||
| "/telemetry": typeof TelemetryRouteRoute; | ||
| '/': typeof IndexRoute | ||
| '/analytics': typeof AnalyticsRouteRoute | ||
| '/data-visualization': typeof DataVisualizationRouteRoute | ||
| '/reconnect': typeof ReconnectRouteRoute | ||
| '/sql-helpers': typeof SqlHelpersRouteRoute | ||
| '/telemetry': typeof TelemetryRouteRoute | ||
| } | ||
| export interface FileRoutesByTo { | ||
| "/": typeof IndexRoute; | ||
| "/analytics": typeof AnalyticsRouteRoute; | ||
| "/data-visualization": typeof DataVisualizationRouteRoute; | ||
| "/reconnect": typeof ReconnectRouteRoute; | ||
| "/telemetry": typeof TelemetryRouteRoute; | ||
| '/': typeof IndexRoute | ||
| '/analytics': typeof AnalyticsRouteRoute | ||
| '/data-visualization': typeof DataVisualizationRouteRoute | ||
| '/reconnect': typeof ReconnectRouteRoute | ||
| '/sql-helpers': typeof SqlHelpersRouteRoute | ||
| '/telemetry': typeof TelemetryRouteRoute | ||
| } | ||
| export interface FileRoutesById { | ||
| __root__: typeof rootRouteImport; | ||
| "/": typeof IndexRoute; | ||
| "/analytics": typeof AnalyticsRouteRoute; | ||
| "/data-visualization": typeof DataVisualizationRouteRoute; | ||
| "/reconnect": typeof ReconnectRouteRoute; | ||
| "/telemetry": typeof TelemetryRouteRoute; | ||
| __root__: typeof rootRouteImport | ||
| '/': typeof IndexRoute | ||
| '/analytics': typeof AnalyticsRouteRoute | ||
| '/data-visualization': typeof DataVisualizationRouteRoute | ||
| '/reconnect': typeof ReconnectRouteRoute | ||
| '/sql-helpers': typeof SqlHelpersRouteRoute | ||
| '/telemetry': typeof TelemetryRouteRoute | ||
| } | ||
| export interface FileRouteTypes { | ||
| fileRoutesByFullPath: FileRoutesByFullPath; | ||
| fileRoutesByFullPath: FileRoutesByFullPath | ||
| fullPaths: | ||
| | "/" | ||
| | "/analytics" | ||
| | "/data-visualization" | ||
| | "/reconnect" | ||
| | "/telemetry"; | ||
| fileRoutesByTo: FileRoutesByTo; | ||
| to: "/" | "/analytics" | "/data-visualization" | "/reconnect" | "/telemetry"; | ||
| | '/' | ||
| | '/analytics' | ||
| | '/data-visualization' | ||
| | '/reconnect' | ||
| | '/sql-helpers' | ||
| | '/telemetry' | ||
| fileRoutesByTo: FileRoutesByTo | ||
| to: | ||
| | '/' | ||
| | '/analytics' | ||
| | '/data-visualization' | ||
| | '/reconnect' | ||
| | '/sql-helpers' | ||
| | '/telemetry' | ||
| id: | ||
| | "__root__" | ||
| | "/" | ||
| | "/analytics" | ||
| | "/data-visualization" | ||
| | "/reconnect" | ||
| | "/telemetry"; | ||
| fileRoutesById: FileRoutesById; | ||
| | '__root__' | ||
| | '/' | ||
| | '/analytics' | ||
| | '/data-visualization' | ||
| | '/reconnect' | ||
| | '/sql-helpers' | ||
| | '/telemetry' | ||
| fileRoutesById: FileRoutesById | ||
| } | ||
| export interface RootRouteChildren { | ||
| IndexRoute: typeof IndexRoute; | ||
| AnalyticsRouteRoute: typeof AnalyticsRouteRoute; | ||
| DataVisualizationRouteRoute: typeof DataVisualizationRouteRoute; | ||
| ReconnectRouteRoute: typeof ReconnectRouteRoute; | ||
| TelemetryRouteRoute: typeof TelemetryRouteRoute; | ||
| IndexRoute: typeof IndexRoute | ||
| AnalyticsRouteRoute: typeof AnalyticsRouteRoute | ||
| DataVisualizationRouteRoute: typeof DataVisualizationRouteRoute | ||
| ReconnectRouteRoute: typeof ReconnectRouteRoute | ||
| SqlHelpersRouteRoute: typeof SqlHelpersRouteRoute | ||
| TelemetryRouteRoute: typeof TelemetryRouteRoute | ||
| } | ||
| declare module "@tanstack/react-router" { | ||
| declare module '@tanstack/react-router' { | ||
| interface FileRoutesByPath { | ||
| "/telemetry": { | ||
| id: "/telemetry"; | ||
| path: "/telemetry"; | ||
| fullPath: "/telemetry"; | ||
| preLoaderRoute: typeof TelemetryRouteRouteImport; | ||
| parentRoute: typeof rootRouteImport; | ||
| }; | ||
| "/reconnect": { | ||
| id: "/reconnect"; | ||
| path: "/reconnect"; | ||
| fullPath: "/reconnect"; | ||
| preLoaderRoute: typeof ReconnectRouteRouteImport; | ||
| parentRoute: typeof rootRouteImport; | ||
| }; | ||
| "/data-visualization": { | ||
| id: "/data-visualization"; | ||
| path: "/data-visualization"; | ||
| fullPath: "/data-visualization"; | ||
| preLoaderRoute: typeof DataVisualizationRouteRouteImport; | ||
| parentRoute: typeof rootRouteImport; | ||
| }; | ||
| "/analytics": { | ||
| id: "/analytics"; | ||
| path: "/analytics"; | ||
| fullPath: "/analytics"; | ||
| preLoaderRoute: typeof AnalyticsRouteRouteImport; | ||
| parentRoute: typeof rootRouteImport; | ||
| }; | ||
| "/": { | ||
| id: "/"; | ||
| path: "/"; | ||
| fullPath: "/"; | ||
| preLoaderRoute: typeof IndexRouteImport; | ||
| parentRoute: typeof rootRouteImport; | ||
| }; | ||
| '/telemetry': { | ||
| id: '/telemetry' | ||
| path: '/telemetry' | ||
| fullPath: '/telemetry' | ||
| preLoaderRoute: typeof TelemetryRouteRouteImport | ||
| parentRoute: typeof rootRouteImport | ||
| } | ||
| '/sql-helpers': { | ||
| id: '/sql-helpers' | ||
| path: '/sql-helpers' | ||
| fullPath: '/sql-helpers' | ||
| preLoaderRoute: typeof SqlHelpersRouteRouteImport | ||
| parentRoute: typeof rootRouteImport | ||
| } | ||
| '/reconnect': { | ||
| id: '/reconnect' | ||
| path: '/reconnect' | ||
| fullPath: '/reconnect' | ||
| preLoaderRoute: typeof ReconnectRouteRouteImport | ||
| parentRoute: typeof rootRouteImport | ||
| } | ||
| '/data-visualization': { | ||
| id: '/data-visualization' | ||
| path: '/data-visualization' | ||
| fullPath: '/data-visualization' | ||
| preLoaderRoute: typeof DataVisualizationRouteRouteImport | ||
| parentRoute: typeof rootRouteImport | ||
| } | ||
| '/analytics': { | ||
| id: '/analytics' | ||
| path: '/analytics' | ||
| fullPath: '/analytics' | ||
| preLoaderRoute: typeof AnalyticsRouteRouteImport | ||
| parentRoute: typeof rootRouteImport | ||
| } | ||
| '/': { | ||
| id: '/' | ||
| path: '/' | ||
| fullPath: '/' | ||
| preLoaderRoute: typeof IndexRouteImport | ||
| parentRoute: typeof rootRouteImport | ||
| } | ||
| } | ||
| } | ||
| @@ -135,8 +160,9 @@ const rootRouteChildren: RootRouteChildren = { | ||
| AnalyticsRouteRoute: AnalyticsRouteRoute, | ||
| DataVisualizationRouteRoute: DataVisualizationRouteRoute, | ||
| ReconnectRouteRoute: ReconnectRouteRoute, | ||
| SqlHelpersRouteRoute: SqlHelpersRouteRoute, | ||
| TelemetryRouteRoute: TelemetryRouteRoute, | ||
| }; | ||
| } | ||
| export const routeTree = rootRouteImport | ||
| ._addFileChildren(rootRouteChildren) | ||
| ._addFileTypes<FileRouteTypes>(); | ||
| ._addFileTypes<FileRouteTypes>() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 9 additions & 10 deletions
19 apps/dev-playground/client/src/routes/data-visualization.route.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.