Skip to content

Allow use of variables references in primitive non-string fields - #1219

Merged
pietern merged 2 commits into
mainfrom
variable-for-non-string-fields
Feb 19, 2024
Merged

Allow use of variables references in primitive non-string fields#1219
pietern merged 2 commits into
mainfrom
variable-for-non-string-fields

Conversation

@pietern

Copy link
Copy Markdown
Contributor

Changes

This change enables the use of bundle variables for boolean, integer, and floating point fields.

Tests

  • Unit tests.
  • I ran a manual test to confirm parameterizing the number of workers in a cluster definition works.

@codecov-commenter

codecov-commenter commented Feb 16, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f70ec35) 52.53% compared to head (58bcb2c) 52.62%.

FilesPatch %Lines
...ndle/config/mutator/resolve_variable_references.go27.27%6 Missing and 2 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1219 +/- ##
==========================================
+ Coverage 52.53% 52.62% +0.08% 
==========================================
Files 308 308 Lines 17160 17208 +48 ==========================================
+ Hits 9015 9055 +40 - Misses 7481 7487 +6 - Partials 664 666 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pietern
pietern added this pull request to the merge queueFeb 19, 2024
Merged via the queue into main with commit a2a4948Feb 19, 2024
@pietern
pietern deleted the variable-for-non-string-fields branch February 19, 2024 10:51
andrewnester added a commit that referenced this pull request Feb 20, 2024
CLI:
* Add support for UC Volumes to the `databricks fs` commands ([#1209](#1209)).
Bundles:
* Use dynamic configuration model in bundles ([#1098](#1098)).
* Allow use of variables references in primitive non-string fields ([#1219](#1219)).
* Add an experimental default-sql template ([#1051](#1051)).
* Add an experimental dbt-sql template ([#1059](#1059)).
Internal:
* Add fork-user to winget release workflow ([#1214](#1214)).
* Use `any` as type for data sources and resources in `tf/schema` ([#1216](#1216)).
* Avoid infinite recursion when normalizing a recursive type ([#1213](#1213)).
* Fix issue where interpolating a new ref would rewrite unrelated fields ([#1217](#1217)).
* Use `dyn.Value` as input to generating Terraform JSON ([#1218](#1218)).
API Changes:
* Changed `databricks lakehouse-monitors update` command with new required argument order.
* Added `databricks online-tables` command group.
OpenAPI commit cdd76a98a4fca7008572b3a94427566dd286c63b (2024-02-19)
Dependency updates:
* Bump Terraform provider to v1.36.2 ([#1215](#1215)).
* Bump github.com/databricks/databricks-sdk-go from 0.32.0 to 0.33.0 ([#1222](#1222)).
@andrewnesterandrewnester mentioned this pull request Feb 20, 2024
github-merge-queueBot pushed a commit that referenced this pull request Feb 20, 2024
CLI:
* Add support for UC Volumes to the `databricks fs` commands
([#1209](#1209)).
Bundles:
* Use dynamic configuration model in bundles
([#1098](#1098)).
* Allow use of variables references in primitive non-string fields
([#1219](#1219)).
* Add an experimental default-sql template
([#1051](#1051)).
* Add an experimental dbt-sql template
([#1059](#1059)).
Internal:
* Add fork-user to winget release workflow
([#1214](#1214)).
* Use `any` as type for data sources and resources in `tf/schema`
([#1216](#1216)).
* Avoid infinite recursion when normalizing a recursive type
([#1213](#1213)).
* Fix issue where interpolating a new ref would rewrite unrelated fields
([#1217](#1217)).
* Use `dyn.Value` as input to generating Terraform JSON
([#1218](#1218)).
API Changes:
* Changed `databricks lakehouse-monitors update` command with new
required argument order.
* Added `databricks online-tables` command group.
OpenAPI commit cdd76a98a4fca7008572b3a94427566dd286c63b (2024-02-19)
Dependency updates:
* Bump Terraform provider to v1.36.2
([#1215](#1215)).
* Bump github.com/databricks/databricks-sdk-go from 0.32.0 to 0.33.0
([#1222](#1222)).
pietern added a commit to databricks/bundle-examples that referenced this pull request Oct 21, 2024
denik pushed a commit that referenced this pull request May 20, 2026
## Changes
This change enables the use of bundle variables for boolean, integer,
and floating point fields.
## Tests
* Unit tests.
* I ran a manual test to confirm parameterizing the number of workers in
a cluster definition works.
denik pushed a commit that referenced this pull request May 20, 2026
CLI:
* Add support for UC Volumes to the `databricks fs` commands
([#1209](#1209)).
Bundles:
* Use dynamic configuration model in bundles
([#1098](#1098)).
* Allow use of variables references in primitive non-string fields
([#1219](#1219)).
* Add an experimental default-sql template
([#1051](#1051)).
* Add an experimental dbt-sql template
([#1059](#1059)).
Internal:
* Add fork-user to winget release workflow
([#1214](#1214)).
* Use `any` as type for data sources and resources in `tf/schema`
([#1216](#1216)).
* Avoid infinite recursion when normalizing a recursive type
([#1213](#1213)).
* Fix issue where interpolating a new ref would rewrite unrelated fields
([#1217](#1217)).
* Use `dyn.Value` as input to generating Terraform JSON
([#1218](#1218)).
API Changes:
* Changed `databricks lakehouse-monitors update` command with new
required argument order.
* Added `databricks online-tables` command group.
OpenAPI commit cdd76a98a4fca7008572b3a94427566dd286c63b (2024-02-19)
Dependency updates:
* Bump Terraform provider to v1.36.2
([#1215](#1215)).
* Bump github.com/databricks/databricks-sdk-go from 0.32.0 to 0.33.0
([#1222](#1222)).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pietern@codecov-commenter@andrewnester