Skip to content

Fix CLI nightlies on our UC workspaces - #1225

Merged
shreyas-goenka merged 3 commits into
mainfrom
uc-on-cli
Feb 21, 2024
Merged

Fix CLI nightlies on our UC workspaces#1225
shreyas-goenka merged 3 commits into
mainfrom
uc-on-cli

Conversation

@shreyas-goenka

Copy link
Copy Markdown
Contributor

This PR fixes some test helper functions so that they work properly on our test environments for AWS and Azure UC workspaces.

@codecov-commenter

codecov-commenter commented Feb 20, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ffae10d) 51.94% compared to head (22623ab) 52.60%.
Report is 9 commits behind head on main.

FilesPatch %Lines
internal/helpers.go0.00%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1225 +/- ##
==========================================
+ Coverage 51.94% 52.60% +0.65% 
==========================================
Files 301 308 +7 Lines 16804 17223 +419 ==========================================
+ Hits 8729 9060 +331 - Misses 7436 7495 +59 - Partials 639 668 +29 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shreyas-goenkashreyas-goenka changed the title Fix CLI nightlies to run on UC workspacesFix CLI nightlies on our UC workspacesFeb 20, 2024
Comment threadinternal/helpers.go Outdated
@shreyas-goenka
shreyas-goenka added this pull request to the merge queueFeb 21, 2024
Merged via the queue into main with commit 4ac1c16Feb 21, 2024
@shreyas-goenka
shreyas-goenka deleted the uc-on-cli branch February 21, 2024 13:13
andrewnester added a commit that referenced this pull request Feb 23, 2024
CLI:
* Improved error message when no .databrickscfg ([#1223](#1223)).
* Use Go SDK Iterators when listing resources with the CLI ([#1202](#1202)).
Bundles:
* Only set ComputeID value when `--compute-id` flag provided ([#1229](#1229)).
* Add correct tag value for models in dev mode ([#1230](#1230)).
* Upgrade Terraform provider to 1.37.0 ([#1235](#1235)).
Internal:
* Fix CLI nightlies on our UC workspaces ([#1225](#1225)).
* Handle alias types for map keys in toTyped conversion ([#1232](#1232)).
@andrewnesterandrewnester mentioned this pull request Feb 23, 2024
github-merge-queueBot pushed a commit that referenced this pull request Feb 23, 2024
CLI:
* Improved error message when no .databrickscfg
([#1223](#1223)).
* Use Go SDK Iterators when listing resources with the CLI
([#1202](#1202)).
Bundles:
* Only set ComputeID value when `--compute-id` flag provided
([#1229](#1229)).
* Add correct tag value for models in dev mode
([#1230](#1230)).
* Upgrade Terraform provider to 1.37.0
([#1235](#1235)).
Internal:
* Fix CLI nightlies on our UC workspaces
([#1225](#1225)).
* Handle alias types for map keys in toTyped conversion
([#1232](#1232)).
denik pushed a commit that referenced this pull request May 20, 2026
This PR fixes some test helper functions so that they work properly on
our test environments for AWS and Azure UC workspaces.
denik pushed a commit that referenced this pull request May 20, 2026
CLI:
* Improved error message when no .databrickscfg
([#1223](#1223)).
* Use Go SDK Iterators when listing resources with the CLI
([#1202](#1202)).
Bundles:
* Only set ComputeID value when `--compute-id` flag provided
([#1229](#1229)).
* Add correct tag value for models in dev mode
([#1230](#1230)).
* Upgrade Terraform provider to 1.37.0
([#1235](#1235)).
Internal:
* Fix CLI nightlies on our UC workspaces
([#1225](#1225)).
* Handle alias types for map keys in toTyped conversion
([#1232](#1232)).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@shreyas-goenka@codecov-commenter@andrewnester