Uh oh!
There was an error while loading. Please reload this page.
[DONTMERGE] Refine experimental SQL template based on multi-statement support - #1289
Closed
lennartkats-db wants to merge 3 commits into
Closed
[DONTMERGE] Refine experimental SQL template based on multi-statement support#1289lennartkats-db wants to merge 3 commits into
lennartkats-db wants to merge 3 commits into
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #1289 +/- ##
==========================================
+ Coverage 52.25% 53.80% +1.55%
==========================================
Files 317 322 +5 Lines 18004 14570 -3434 ==========================================
- Hits 9408 7840 -1568 + Misses 7903 6002 -1901 - Partials 693 728 +35 ☔ View full report in Codecov by Sentry. |
pietern
commented
Mar 18, 2024
Contributor
@lennartkats-db What is the (rough) ETA for this? |
This reverts commit 95fc745.
lennartkats-db
commented
Mar 20, 2024
ContributorAuthor
This should land somewhere within the next few weeks. |
| CREATE OR REPLACE VIEW | ||
| IDENTIFIER(CONCAT({{"{{"}}catalog{{"}}"}}, '.', {{"{{"}}schema{{"}}"}}, '.', 'orders_daily')) | ||
| USE CATALOG {{"{{"}}catalog{{"}}"}}; | ||
| USE SCHEMA {{"{{"}}schema{{"}}"}}; |
ContributorAuthor
There was a problem hiding this comment.
Suggested change
| USE SCHEMA {{"{{"}}schema{{"}}"}}; | |
| USE SCHEMA SYMBOL({{"{{"}}schema{{"}}"}}); |
Unfortunately the schema requires SYMBOL().
lennartkats-db
commented
Jun 4, 2024
ContributorAuthor
Closing in favor of #1463. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR refines the experimental SQL template based on (the upcoming) multi-statement support.