Skip to content

Do not emit warning on YAML anchor blocks - #1354

Merged
andrewnester merged 2 commits into
mainfrom
fix/yaml-anchor-warning
Apr 10, 2024
Merged

Do not emit warning on YAML anchor blocks#1354
andrewnester merged 2 commits into
mainfrom
fix/yaml-anchor-warning

Conversation

@andrewnester

Copy link
Copy Markdown
Contributor

Changes

In 0.217.0 we started to emit warning on unknown fields in YAML configuration but wrongly considered YAML anchor blocks as unknown field.

This PR fixes this by skipping normalising of YAML blocks.

Tests

Added regression tests

@andrewnester
andrewnester added this pull request to the merge queueApr 10, 2024
Merged via the queue into main with commit d914a1bApr 10, 2024
@andrewnester
andrewnester deleted the fix/yaml-anchor-warning branch April 10, 2024 10:01
andrewnester added a commit that referenced this pull request Apr 10, 2024
CLI:
* Don't attempt auth in `auth profiles --skip-validate` ([#1282](#1282)).
* Fixed typo in error template for auth describe ([#1341](#1341)).
Bundles:
* Correctly transform libraries in for_each_task block ([#1340](#1340)).
* Do not emit warning on YAML anchor blocks ([#1354](#1354)).
* Fixed pre-init script order ([#1348](#1348)).
* Execute preinit after entry point to make sure scripts are loaded ([#1351](#1351)).
Dependency updates:
* Bump internal terraform provider version to `1.39` ([#1339](#1339)).
* Bump golang.org/x/term from 0.18.0 to 0.19.0 ([#1343](#1343)).
* Bump github.com/hashicorp/hc-install from 0.6.3 to 0.6.4 ([#1344](#1344)).
* Bump golang.org/x/mod from 0.16.0 to 0.17.0 ([#1345](#1345)).
* Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 ([#1347](#1347)).
* Bump golang.org/x/sync from 0.6.0 to 0.7.0 ([#1346](#1346)).
@andrewnesterandrewnester mentioned this pull request Apr 10, 2024
github-merge-queueBot pushed a commit that referenced this pull request Apr 10, 2024
CLI:
* Don't attempt auth in `auth profiles --skip-validate`
([#1282](#1282)).
* Fixed typo in error template for auth describe
([#1341](#1341)).
Bundles:
* Correctly transform libraries in for_each_task block
([#1340](#1340)).
* Do not emit warning on YAML anchor blocks
([#1354](#1354)).
* Fixed pre-init script order
([#1348](#1348)).
* Execute preinit after entry point to make sure scripts are loaded
([#1351](#1351)).
Dependency updates:
* Bump internal terraform provider version to `1.39`
([#1339](#1339)).
* Bump golang.org/x/term from 0.18.0 to 0.19.0
([#1343](#1343)).
* Bump github.com/hashicorp/hc-install from 0.6.3 to 0.6.4
([#1344](#1344)).
* Bump golang.org/x/mod from 0.16.0 to 0.17.0
([#1345](#1345)).
* Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0
([#1347](#1347)).
* Bump golang.org/x/sync from 0.6.0 to 0.7.0
([#1346](#1346)).
@andrewnesterandrewnester mentioned this pull request Apr 10, 2024
github-merge-queueBot pushed a commit that referenced this pull request Apr 10, 2024
CLI:
* Don't attempt auth in `auth profiles --skip-validate`
([#1282](#1282)).
* Fixed typo in error template for auth describe
([#1341](#1341)).
Bundles:
* Correctly transform libraries in for_each_task block
([#1340](#1340)).
* Do not emit warning on YAML anchor blocks
([#1354](#1354)).
* Fixed pre-init script order
([#1348](#1348)).
* Execute preinit after entry point to make sure scripts are loaded
([#1351](#1351)).
Dependency updates:
* Bump internal terraform provider version to `1.39`
([#1339](#1339)).
* Bump golang.org/x/term from 0.18.0 to 0.19.0
([#1343](#1343)).
* Bump github.com/hashicorp/hc-install from 0.6.3 to 0.6.4
([#1344](#1344)).
* Bump golang.org/x/mod from 0.16.0 to 0.17.0
([#1345](#1345)).
* Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0
([#1347](#1347)).
* Bump golang.org/x/sync from 0.6.0 to 0.7.0
([#1346](#1346)).
## Changes
<!-- Summary of your changes that are easy to understand -->
## Tests
<!-- How is this tested? -->
denik pushed a commit that referenced this pull request May 20, 2026
## Changes
In 0.217.0 we started to emit warning on unknown fields in YAML
configuration but wrongly considered YAML anchor blocks as unknown
field.
This PR fixes this by skipping normalising of YAML blocks.
## Tests
Added regression tests
denik pushed a commit that referenced this pull request May 20, 2026
CLI:
* Don't attempt auth in `auth profiles --skip-validate`
([#1282](#1282)).
* Fixed typo in error template for auth describe
([#1341](#1341)).
Bundles:
* Correctly transform libraries in for_each_task block
([#1340](#1340)).
* Do not emit warning on YAML anchor blocks
([#1354](#1354)).
* Fixed pre-init script order
([#1348](#1348)).
* Execute preinit after entry point to make sure scripts are loaded
([#1351](#1351)).
Dependency updates:
* Bump internal terraform provider version to `1.39`
([#1339](#1339)).
* Bump golang.org/x/term from 0.18.0 to 0.19.0
([#1343](#1343)).
* Bump github.com/hashicorp/hc-install from 0.6.3 to 0.6.4
([#1344](#1344)).
* Bump golang.org/x/mod from 0.16.0 to 0.17.0
([#1345](#1345)).
* Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0
([#1347](#1347)).
* Bump golang.org/x/sync from 0.6.0 to 0.7.0
([#1346](#1346)).
denik pushed a commit that referenced this pull request May 20, 2026
CLI:
* Don't attempt auth in `auth profiles --skip-validate`
([#1282](#1282)).
* Fixed typo in error template for auth describe
([#1341](#1341)).
Bundles:
* Correctly transform libraries in for_each_task block
([#1340](#1340)).
* Do not emit warning on YAML anchor blocks
([#1354](#1354)).
* Fixed pre-init script order
([#1348](#1348)).
* Execute preinit after entry point to make sure scripts are loaded
([#1351](#1351)).
Dependency updates:
* Bump internal terraform provider version to `1.39`
([#1339](#1339)).
* Bump golang.org/x/term from 0.18.0 to 0.19.0
([#1343](#1343)).
* Bump github.com/hashicorp/hc-install from 0.6.3 to 0.6.4
([#1344](#1344)).
* Bump golang.org/x/mod from 0.16.0 to 0.17.0
([#1345](#1345)).
* Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0
([#1347](#1347)).
* Bump golang.org/x/sync from 0.6.0 to 0.7.0
([#1346](#1346)).
## Changes
<!-- Summary of your changes that are easy to understand -->
## Tests
<!-- How is this tested? -->
denik pushed a commit that referenced this pull request May 20, 2026
CLI:
* Don't attempt auth in `auth profiles --skip-validate`
([#1282](#1282)).
* Fixed typo in error template for auth describe
([#1341](#1341)).
Bundles:
* Correctly transform libraries in for_each_task block
([#1340](#1340)).
* Do not emit warning on YAML anchor blocks
([#1354](#1354)).
* Fixed pre-init script order
([#1348](#1348)).
* Execute preinit after entry point to make sure scripts are loaded
([#1351](#1351)).
Dependency updates:
* Bump internal terraform provider version to `1.39`
([#1339](#1339)).
* Bump golang.org/x/term from 0.18.0 to 0.19.0
([#1343](#1343)).
* Bump github.com/hashicorp/hc-install from 0.6.3 to 0.6.4
([#1344](#1344)).
* Bump golang.org/x/mod from 0.16.0 to 0.17.0
([#1345](#1345)).
* Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0
([#1347](#1347)).
* Bump golang.org/x/sync from 0.6.0 to 0.7.0
([#1346](#1346)).
## Changes
<!-- Summary of your changes that are easy to understand -->
## Tests
<!-- How is this tested? -->
denik pushed a commit that referenced this pull request May 20, 2026
CLI:
* Don't attempt auth in `auth profiles --skip-validate`
([#1282](#1282)).
* Fixed typo in error template for auth describe
([#1341](#1341)).
Bundles:
* Correctly transform libraries in for_each_task block
([#1340](#1340)).
* Do not emit warning on YAML anchor blocks
([#1354](#1354)).
* Fixed pre-init script order
([#1348](#1348)).
* Execute preinit after entry point to make sure scripts are loaded
([#1351](#1351)).
Dependency updates:
* Bump internal terraform provider version to `1.39`
([#1339](#1339)).
* Bump golang.org/x/term from 0.18.0 to 0.19.0
([#1343](#1343)).
* Bump github.com/hashicorp/hc-install from 0.6.3 to 0.6.4
([#1344](#1344)).
* Bump golang.org/x/mod from 0.16.0 to 0.17.0
([#1345](#1345)).
* Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0
([#1347](#1347)).
* Bump golang.org/x/sync from 0.6.0 to 0.7.0
([#1346](#1346)).
## Changes
<!-- Summary of your changes that are easy to understand -->
## Tests
<!-- How is this tested? -->
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewnester@shreyas-goenka