Skip to content

Fix variable overrides in targets for non-string variables - #1397

Merged
shreyas-goenka merged 2 commits into
mainfrom
fix/variable-override-non-string
Apr 25, 2024
Merged

Fix variable overrides in targets for non-string variables#1397
shreyas-goenka merged 2 commits into
mainfrom
fix/variable-override-non-string

Conversation

@shreyas-goenka

@shreyas-goenkashreyas-goenka commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Before variable overrides that were not string in a target would not work. This PR fixes that. Tested manually and via a unit test.

@shreyas-goenka
shreyas-goenka requested review from andrewnester and pietern and removed request for pieternApril 24, 2024 14:45
@shreyas-goenka
shreyas-goenka added this pull request to the merge queueApr 25, 2024
Merged via the queue into main with commit e652333Apr 25, 2024
@shreyas-goenka
shreyas-goenka deleted the fix/variable-override-non-string branch April 25, 2024 11:28
pietern added a commit that referenced this pull request Apr 25, 2024
This is a bugfix release.
CLI:
* Pass `DATABRICKS_CONFIG_FILE` for `auth profiles` ([#1394](#1394)).
Bundles:
* Show a better error message for using wheel tasks with older DBR versions ([#1373](#1373)).
* Allow variable references in non-string fields in the JSON schema ([#1398](#1398)).
* Fix variable overrides in targets for non-string variables ([#1397](#1397)).
* Fix bundle schema for variables ([#1396](#1396)).
* Fix bundle documentation URL ([#1399](#1399)).
Internal:
* Removed autogenerated docs for the CLI commands ([#1392](#1392)).
* Remove `JSON.parse` call from homebrew-tap action ([#1393](#1393)).
* Ensure that Python dependencies are installed during upgrade ([#1390](#1390)).
@pieternpietern mentioned this pull request Apr 25, 2024
github-merge-queueBot pushed a commit that referenced this pull request Apr 25, 2024
This is a bugfix release.
CLI:
* Pass `DATABRICKS_CONFIG_FILE` for `auth profiles`
([#1394](#1394)).
Bundles:
* Show a better error message for using wheel tasks with older DBR
versions ([#1373](#1373)).
* Allow variable references in non-string fields in the JSON schema
([#1398](#1398)).
* Fix variable overrides in targets for non-string variables
([#1397](#1397)).
* Fix bundle schema for variables
([#1396](#1396)).
* Fix bundle documentation URL
([#1399](#1399)).
Internal:
* Removed autogenerated docs for the CLI commands
([#1392](#1392)).
* Remove `JSON.parse` call from homebrew-tap action
([#1393](#1393)).
* Ensure that Python dependencies are installed during upgrade
([#1390](#1390)).
denik pushed a commit that referenced this pull request May 20, 2026
Before variable overrides that were not string in a target would not
work. This PR fixes that. Tested manually and via a unit test.
denik pushed a commit that referenced this pull request May 20, 2026
This is a bugfix release.
CLI:
* Pass `DATABRICKS_CONFIG_FILE` for `auth profiles`
([#1394](#1394)).
Bundles:
* Show a better error message for using wheel tasks with older DBR
versions ([#1373](#1373)).
* Allow variable references in non-string fields in the JSON schema
([#1398](#1398)).
* Fix variable overrides in targets for non-string variables
([#1397](#1397)).
* Fix bundle schema for variables
([#1396](#1396)).
* Fix bundle documentation URL
([#1399](#1399)).
Internal:
* Removed autogenerated docs for the CLI commands
([#1392](#1392)).
* Remove `JSON.parse` call from homebrew-tap action
([#1393](#1393)).
* Ensure that Python dependencies are installed during upgrade
([#1390](#1390)).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@shreyas-goenka@pietern