Uh oh!
There was an error while loading. Please reload this page.
Remove unnecessary filepath.FromSlash calls - #1458
Merged
Merged
Conversation
The prior join call calls `filepath.Join`, which returns a cleaned result. Path cleaning in turn calls `filepath.FromSlash`.
pietern
commented
May 29, 2024
ContributorAuthor
Per #1452 (review) |
filepath.FromSlash callspietern
enabled auto-merge
May 29, 2024 13:32
andrewnester
approved these changes
May 29, 2024
andrewnester
commented
May 29, 2024
Contributor
Removed from queue for now because it should be merged after #1452 , correct? |
shreyas-goenka
approved these changes
May 29, 2024
pietern
commented
May 29, 2024
ContributorAuthor
@andrewnester No, this is independent (and local to the local filer). |
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes The prior join call calls `filepath.Join` which returns a cleaned result. Path cleaning, in turn, calls `filepath.FromSlash`. ## Tests * Unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The prior join call calls
filepath.Joinwhich returns a cleaned result.Path cleaning, in turn, calls
filepath.FromSlash.Tests