Skip to content

Fix SQL schema selection in default-sql template - #1471

Merged
lennartkats-db merged 1 commit into
databricks:mainfrom
lennartkats-db:fix-sql-schema
Jun 4, 2024
Merged

Fix SQL schema selection in default-sql template#1471
lennartkats-db merged 1 commit into
databricks:mainfrom
lennartkats-db:fix-sql-schema

Conversation

@lennartkats-db

Copy link
Copy Markdown
Contributor

Changes

This fixes a last-minute regression that snuck into #1463: unfortunately we need to use USE IDENTIFIER('schema') to select a schema for now. In the future we expect we can just use USE SCHEMA 'schema'.

We need to use identifier() for now
@codecov-commenter

codecov-commenter commented Jun 4, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.57%. Comparing base (e22dd8a) to head (425ea66).
Report is 131 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1471 +/- ##
==========================================
+ Coverage 52.25% 53.57% +1.31% 
==========================================
Files 317 351 +34 Lines 18004 20271 +2267 ==========================================
+ Hits 9408 10860 +1452 - Misses 7903 8612 +709 - Partials 693 799 +106 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lennartkats-db
lennartkats-db added this pull request to the merge queueJun 4, 2024
Merged via the queue into databricks:main with commit 4bc0ea0Jun 4, 2024
@lennartkats-db
lennartkats-db deleted the fix-sql-schema branch June 4, 2024 15:49
pietern added a commit that referenced this pull request Jun 5, 2024
Bundles:
This releases fixes an issue introduced in v0.221.0 where managing jobs with a single-node cluster would fail.
* Fix SQL schema selection in default-sql template ([#1471](#1471)).
* Copy-editing for SQL templates ([#1474](#1474)).
* Upgrade TF provider to 1.47.0 ([#1476](#1476)).
Internal:
* Use latest version of goreleaser action ([#1477](#1477)).
@pieternpietern mentioned this pull request Jun 5, 2024
github-merge-queueBot pushed a commit that referenced this pull request Jun 5, 2024
Bundles:
This releases fixes an issue introduced in v0.221.0 where managing jobs
with a single-node cluster would fail.
* Fix SQL schema selection in default-sql template
([#1471](#1471)).
* Copy-editing for SQL templates
([#1474](#1474)).
* Upgrade TF provider to 1.47.0
([#1476](#1476)).
Internal:
* Use latest version of goreleaser action
([#1477](#1477)).
denik pushed a commit that referenced this pull request May 20, 2026
## Changes
This fixes a last-minute regression that snuck into
#1463: unfortunately we need to
use `USE IDENTIFIER('schema')` to select a schema for now. In the future
we expect we can just use `USE SCHEMA 'schema'`.
denik pushed a commit that referenced this pull request May 20, 2026
Bundles:
This releases fixes an issue introduced in v0.221.0 where managing jobs
with a single-node cluster would fail.
* Fix SQL schema selection in default-sql template
([#1471](#1471)).
* Copy-editing for SQL templates
([#1474](#1474)).
* Upgrade TF provider to 1.47.0
([#1476](#1476)).
Internal:
* Use latest version of goreleaser action
([#1477](#1477)).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lennartkats-db@codecov-commenter@pietern