Uh oh!
There was an error while loading. Please reload this page.
Print diagnostics in 'bundle deploy' - #1579
Merged
Merged
Conversation
pietern
reviewed
Jul 10, 2024
pietern
left a comment
Contributor
There was a problem hiding this comment.
This is a good step, but only half of a solution.
The validate command doesn't have side effects, so you can naturally decide whether to address the warnings or run with them. This is not the case for deploy, where we'll continue and do the actual deployment regardless of warnings.
Let's pair this with other changes that:
- Make it possible to treat warnings as errors
- Can stream warnings as they happen as opposed to delaying them until the end of execution
Uh oh!
There was an error while loading. Please reload this page.
kanterov
commented
Jul 10, 2024
CollaboratorAuthor
@pietern I agree with your points. Do you think this is something we can do as a follow-up? With this change, we don't change the existing execution flow, and the points you mentioned are already true. However, it addresses the problem of users not being aware of warnings at all and adds pretty-printing of errors/warnings, which is useful when they have source location and additional details. |
pietern
reviewed
Jul 10, 2024
Uh oh!
There was an error while loading. Please reload this page.
pietern
commented
Jul 10, 2024
Contributor
I triggered nightlies on this change to confirm they fail for the lack of exit status. If they don't we'll need to address that as well. |
andrewnester
approved these changes
Jul 10, 2024
shreyas-goenka
approved these changes
Jul 10, 2024
kanterov
commented
Jul 10, 2024
CollaboratorAuthor
@pietern updated PR description with more examples, there is 1 extra trailing new line, which would be hard to get rid of due to how we use go template, unless we do extra buffering |
pietern
commented
Jul 10, 2024
Contributor
We can revisit the exact output and make those newlines disappear later. |
andrewnester added a commit
that referenced
this pull request
Jul 10, 2024
Bundles: * Override complex variables with target overrides instead of merging ([#1567](#1567)). * Rewrite local path for libraries in foreach tasks ([#1569](#1569)). * Change SetVariables mutator to mutate dynamic configuration instead ([#1573](#1573)). * Return early in bundle destroy if no deployment exists ([#1581](#1581)). * Let notebook detection code use underlying metadata if available ([#1574](#1574)). * Remove schema override for variable default value ([#1536](#1536)). * Print diagnostics in 'bundle deploy' ([#1579](#1579)). Internal: * Update actions/upload-artifact to v4 ([#1559](#1559)). * Use Go 1.22 to build and test ([#1562](#1562)). * Move bespoke status call to main workspace files filer ([#1570](#1570)). * Add new template ([#1578](#1578)). * Add regression tests for CLI error output ([#1566](#1566)). Dependency updates: * Bump golang.org/x/mod from 0.18.0 to 0.19.0 ([#1576](#1576)). * Bump golang.org/x/term from 0.21.0 to 0.22.0 ([#1577](#1577)).
Merged
github-merge-queueBot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Bundles: * Override complex variables with target overrides instead of merging ([#1567](#1567)). * Rewrite local path for libraries in foreach tasks ([#1569](#1569)). * Change SetVariables mutator to mutate dynamic configuration instead ([#1573](#1573)). * Return early in bundle destroy if no deployment exists ([#1581](#1581)). * Let notebook detection code use underlying metadata if available ([#1574](#1574)). * Remove schema override for variable default value ([#1536](#1536)). * Print diagnostics in 'bundle deploy' ([#1579](#1579)). Internal: * Update actions/upload-artifact to v4 ([#1559](#1559)). * Use Go 1.22 to build and test ([#1562](#1562)). * Move bespoke status call to main workspace files filer ([#1570](#1570)). * Add new template ([#1578](#1578)). * Add regression tests for CLI error output ([#1566](#1566)). Dependency updates: * Bump golang.org/x/mod from 0.18.0 to 0.19.0 ([#1576](#1576)). * Bump golang.org/x/term from 0.21.0 to 0.22.0 ([#1577](#1577)).
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes Print diagnostics in 'bundle deploy' similar to 'bundle validate'. This way if a bundle has any errors or warnings, they are going to be easy to notice. NB: due to how we render errors, there is one extra trailing new line in output, preserved in examples below ## Example: No errors or warnings ``` % databricks bundle deploy Building default... Deploying resources... Updating deployment state... Deployment complete! ``` ## Example: Error on load ``` % databricks bundle deploy Error: Databricks CLI version constraint not satisfied. Required: >= 1337.0.0, current: 0.0.0-dev ``` ## Example: Warning on load ``` % databricks bundle deploy Building default... Deploying resources... Updating deployment state... Deployment complete! Warning: unknown field: foo in databricks.yml:6:1 ``` ## Example: Error + warning on load ``` % databricks bundle deploy Warning: unknown field: foo in databricks.yml:6:1 Error: something went wrong ``` ## Example: Warning on load + error in init ``` % databricks bundle deploy Warning: unknown field: foo in databricks.yml:6:1 Error: Failed to xxx in yyy.yml Detailed explanation in multiple lines ``` ## Tests Tested manually
denik pushed a commit
that referenced
this pull request
May 20, 2026
Bundles: * Override complex variables with target overrides instead of merging ([#1567](#1567)). * Rewrite local path for libraries in foreach tasks ([#1569](#1569)). * Change SetVariables mutator to mutate dynamic configuration instead ([#1573](#1573)). * Return early in bundle destroy if no deployment exists ([#1581](#1581)). * Let notebook detection code use underlying metadata if available ([#1574](#1574)). * Remove schema override for variable default value ([#1536](#1536)). * Print diagnostics in 'bundle deploy' ([#1579](#1579)). Internal: * Update actions/upload-artifact to v4 ([#1559](#1559)). * Use Go 1.22 to build and test ([#1562](#1562)). * Move bespoke status call to main workspace files filer ([#1570](#1570)). * Add new template ([#1578](#1578)). * Add regression tests for CLI error output ([#1566](#1566)). Dependency updates: * Bump golang.org/x/mod from 0.18.0 to 0.19.0 ([#1576](#1576)). * Bump golang.org/x/term from 0.21.0 to 0.22.0 ([#1577](#1577)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Print diagnostics in 'bundle deploy' similar to 'bundle validate'. This way if a bundle has any errors or warnings, they are going to be easy to notice.
NB: due to how we render errors, there is one extra trailing new line in output, preserved in examples below
Example: No errors or warnings
Example: Error on load
Example: Warning on load
Example: Error + warning on load
Example: Warning on load + error in init
Tests
Tested manually