Uh oh!
There was an error while loading. Please reload this page.
Introduce new type for a slice of dyn.Location - #1611
Closed
shreyas-goenka wants to merge 1 commit into
Closed
Conversation
shreyas-goenka
requested review from
andrewnester and pietern
and removed request for
andrewnester and pieternJuly 18, 2024 16:11
shreyas-goenka
commented
Jul 19, 2024
ContributorAuthor
I'll resume work on this PR once #1610 is merged. |
shreyas-goenka
commented
Aug 12, 2024
ContributorAuthor
Meh, not worth it. This PR does not solve any problems so closing it. |
pietern
commented
Aug 13, 2024
Contributor
FWIW, if we would do this it would be good to do the same for paths for symmetry (we use both in diags). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Small quality of life improvement, since we now have multiple locations everywhere in the code.