Uh oh!
There was an error while loading. Please reload this page.
Added test for negation pattern in sync include exclude section - #1637
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| err = createFile(sub2, "g.go") | ||
| require.NoError(t, err) | ||
| err = createFile(sub2, "h.txt") |
There was a problem hiding this comment.
I'd recommend creating these files and directories using for loops, to make the code terser.
There was a problem hiding this comment.
@shreyas-goenka we can't really because we need predictable structure and the files are located in different subdirectories so using loops will make it even less readable
There was a problem hiding this comment.
What do you think about simplifying it like this? The file tree structure is a lot more evident in this case.
for p in {
[]string{dir, "a.go"},
[]string{dir, "b.go"},
...
[]string{dir, ".databricks", "e.go"}
...
[]string{dir, "test", "sub1", "f.go"}
} {
testutil.Touch(t, p...)
}
There was a problem hiding this comment.
Yes, that's a good one, thanks!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
shreyas-goenka
left a comment
There was a problem hiding this comment.
Thanks, looks good to me! Approving to unblock.
Uh oh!
There was an error while loading. Please reload this page.
Bundles: * Add resource for UC schemas to DABs ([#1413](#1413)). Internal: * Use dynamic walking to validate unique resource keys ([#1614](#1614)). * Regenerate TF schema ([#1635](#1635)). * Add upgrade and upgrade eager flags to pip install call ([#1636](#1636)). * Added test for negation pattern in sync include exclude section ([#1637](#1637)). * Use precomputed terraform plan for `bundle deploy` ([#1640](#1640)).
Bundles: * Add resource for UC schemas to DABs ([#1413](#1413)). Internal: * Use dynamic walking to validate unique resource keys ([#1614](#1614)). * Regenerate TF schema ([#1635](#1635)). * Add upgrade and upgrade eager flags to pip install call ([#1636](#1636)). * Added test for negation pattern in sync include exclude section ([#1637](#1637)). * Use precomputed terraform plan for `bundle deploy` ([#1640](#1640)).
## Changes Added test for negation pattern in sync include exclude section
Bundles: * Add resource for UC schemas to DABs ([#1413](#1413)). Internal: * Use dynamic walking to validate unique resource keys ([#1614](#1614)). * Regenerate TF schema ([#1635](#1635)). * Add upgrade and upgrade eager flags to pip install call ([#1636](#1636)). * Added test for negation pattern in sync include exclude section ([#1637](#1637)). * Use precomputed terraform plan for `bundle deploy` ([#1640](#1640)).
Changes
Added test for negation pattern in sync include exclude section