Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 214
Upgrade Go SDK to 0.44.0#1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Upgrade Go SDK to 0.44.0 #1679
Changes from all commits
7b73596346088cfb951fcbebfd12d8e62cc4a07615File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 7437dabb9dadee402c1fc060df4c1ce8cc5369f0 | ||
| f98c07f9c71f579de65d2587bb0292f83d10e55d |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -78,7 +78,7 @@ func (l *UpdateTracker) Events(ctx context.Context) ([]ProgressEvent, error) { | ||
| } | ||
| // we only check the most recent 100 events for progress | ||
| response, err := l.w.Pipelines.Impl().ListPipelineEvents(ctx, pipelines.ListPipelineEventsRequest{ | ||
| events, err := l.w.Pipelines.ListPipelineEventsAll(ctx, pipelines.ListPipelineEventsRequest{ | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
| ||
| PipelineId: l.PipelineId, | ||
| MaxResults: 100, | ||
| Filter: filter, | ||
| @@ -89,8 +89,8 @@ func (l *UpdateTracker) Events(ctx context.Context) ([]ProgressEvent, error) { | ||
| result := make([]ProgressEvent, 0) | ||
| // we iterate in reverse to return events in chronological order | ||
| for i := len(response.Events) - 1; i >= 0; i-- { | ||
| event := response.Events[i] | ||
| for i := len(events) - 1; i >= 0; i-- { | ||
| event := events[i] | ||
| // filter to only include update_progress and flow_progress events | ||
| if event.EventType == "flow_progress" || event.EventType == "update_progress" { | ||
| result = append(result, ProgressEvent(event)) | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implis not exposed from Go SDK anymore