Uh oh!
There was an error while loading. Please reload this page.
Remove unnecessary GET call in pipeline runner - #1850
Merged
Conversation
pietern
commented
Nov 18, 2024
Contributor
@shreyas-goenka Do you want to proceed with this? |
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 18, 2024 15:21 — with 
GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 18, 2024 15:21 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 18, 2024 15:32 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 18, 2024 15:33 — with GitHub Actions
Inactive
eng-dev-ecosystem-bot
commented
Nov 18, 2024
Collaborator
Test Details: go/deco-tests/11895733199 |
denik
approved these changes
Dec 30, 2024
andrewnester
approved these changes
Dec 30, 2024
shreyas-goenkatemporarily deployed
to
test-trigger-is
December 31, 2024 09:30 — with GitHub Actions
Inactive
Contributor
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
shreyas-goenkatemporarily deployed
to
test-trigger-is
December 31, 2024 09:30 — with GitHub Actions
Inactive
shreyas-goenka
enabled auto-merge
December 31, 2024 09:46
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes This GET API call is unnecessary and serves no purpose. Let's remove it. Noticed this when I was adding a unit test for the pipeline runner here: #1849 ## Tests Manually. ### Case 1: The pipeline does not exist Before: ``` ➜ my_project git:(master) ✗ databricks bundle run my_project_pipeline -p dogfood Error: User shreyas.goenka@databricks.com does not have View permissions on pipeline 9941901a-e48b-4d04-b6ba-e0072ad126bg. ``` After: ``` ➜ my_project git:(master) ✗ cli bundle run my_project_pipeline -p dogfood Error: User shreyas.goenka@databricks.com does not have Run permissions on pipeline 9941901a-e48b-4d04-b6ba-e0072ad126bg. ``` ### Case 2: Pipeline exists Before: ``` ➜ my_project git:(master) ✗ databricks bundle run my_project_pipeline -p dogfood --restart Update URL: https://e2-dogfood.staging.cloud.databricks.com/#joblist/pipelines/9941901a-e48b-4d04-b6ba-e0072ad126bf/updates/0f988d62-9ec7-49f1-b429-5572ece3a9aa 2024-11-18T15:30:36.054Z update_progress INFO "Update 0f988d is WAITING_FOR_RESOURCES." ``` After: ``` ➜ my_project git:(master) ✗ cli bundle run my_project_pipeline -p dogfood --restart Update URL: https://e2-dogfood.staging.cloud.databricks.com/#joblist/pipelines/9941901a-e48b-4d04-b6ba-e0072ad126bf/updates/87b43350-6186-4a9b-9d0e-38da2ecf33ae 2024-11-18T15:28:27.144Z update_progress INFO "Update 87b433 is WAITING_FOR_RESOURCES." ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This GET API call is unnecessary and serves no purpose. Let's remove it. Noticed this when I was adding a unit test for the pipeline runner here: #1849
Tests
Manually.
Case 1: The pipeline does not exist
Before:
After:
Case 2: Pipeline exists
Before:
After: