Skip to content

feat(bundle): cluster permissions from root bundle permissions - #1859

Closed
Mike-F-G wants to merge 2 commits into
databricks:mainfrom
Mike-F-G:fix/cluster_permissions
Closed

feat(bundle): cluster permissions from root bundle permissions#1859
Mike-F-G wants to merge 2 commits into
databricks:mainfrom
Mike-F-G:fix/cluster_permissions

Conversation

@Mike-F-G

@Mike-F-GMike-F-G commented Oct 25, 2024

Copy link
Copy Markdown

Issue

Defining permissions at the root of the bundle with the recently added clusters as resources for all purpose clusters are not aligned with expected permissions.

Changes

Add permission conversion for the Databricks Clusters resources according to the cluster ACLs

Tests

Tests aligned with the expected definition

@Mike-F-G
Mike-F-Gforce-pushed the fix/cluster_permissions branch from ab57b6c to faa7963CompareOctober 25, 2024 14:06
@andrewnester

andrewnester commented Oct 29, 2024

Copy link
Copy Markdown
Contributor

@Mike-F-G thanks for the PR! Just to clarify: you had issues when you defined top level bundle permissions but they were not working for clusters, is it correct? Because your PR adds support top level permissions but not really fixes the ones defined inside cluster config itself.

Cluster permissions were fixed in this PR #1826 which was released last week in 0.231.0 version

@Mike-F-G
Mike-F-Gforce-pushed the fix/cluster_permissions branch from faa7963 to 6057cdcCompareOctober 29, 2024 13:47
@Mike-F-G

Copy link
Copy Markdown
Author

@Mike-F-G thanks for the PR! Just to clarify: you had issues when you defined top level bundle permissions but they were not working for clusters, is it correct? Because your PR adds support top level permissions but not really fixes the ones defined inside cluster config itself.

Cluster permissions were fixed in this PR #1826 which was released last week in 0.231.0 version

Thank you for taking the time to consider this PR. Yes you are totally right, I was mistaken on the scope of the PR & the tests related to my change.

My initial issue is indeed fixed with #1826. Therefore let met switch this PR to take into account the bundle level of permissions for the clusters. Aligning the initial modification with its usage.

@Mike-F-GMike-F-G changed the title fix(bundle): cluster permissionsfeat(bundle): cluster permissions from root bundle permissionsOct 29, 2024
@github-actions

Copy link
Copy Markdown
Contributor

This PR has not received an update in a while. If you want to keep this PR open, please leave a comment below or push a new commit and auto-close will be canceled.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Mike-F-G@andrewnester