Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0 by dependabot[bot] · Pull Request #1878 · databricks/cli

dependabot · 2024-11-04T11:44:37Z

Known issues:

(non-blocking with a command override)apps.Update requires 2 name params (one from path, one from request body)
(non-blocking)lakeview.Create does not require positional argument display_name anymore because it's not marked as required in request body

Bumps github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0.

Bumps [github.com/databricks/databricks-sdk-go](https://github.com/databricks/databricks-sdk-go) from 0.49.0 to 0.50.0. - [Release notes](https://github.com/databricks/databricks-sdk-go/releases) - [Changelog](https://github.com/databricks/databricks-sdk-go/blob/main/CHANGELOG.md) - [Commits](databricks/databricks-sdk-go@v0.49.0...v0.50.0) --- updated-dependencies: - dependency-name: github.com/databricks/databricks-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

andrewnester · 2024-11-04T16:20:44Z

@pietern there are some manual changes to dashboard code here, could you TAL?

…databricks-sdk-go-0.50.0

andrewnester · 2024-11-08T13:14:56Z

- Create a draft dashboard.
-
- Arguments:
- DISPLAY_NAME: The display name of the dashboard.`


This seems to be caused by display_name not marked as required in the OpenAPI https://github.com/databricks/databricks-sdk-go/blame/776b63cf7f8f155f7642b0320d2bea0ced011914/service/dashboards/model.go#L54

cc @renaudhartert-db

andrewnester · 2024-11-08T15:19:54Z

+	cmd.Flags().StringVar(&updateReq.App.Url, "url", updateReq.App.Url, `The URL of the app once it is deployed.`)

-	cmd.Use = "update NAME"
+	cmd.Use = "update NAME NAME"


Now NAME param is in both request body and path with no good way for us to disambiguate this when generating. @pietern any ideas how do we address this for CLI? It might as well be necessary to fix it in OpenAPI

cc @renaudhartert-db

pietern · 2024-11-13T11:13:48Z

-	cmd.Flags().StringVar(&createReq.WarehouseId, "warehouse-id", createReq.WarehouseId, `The warehouse ID used to run the dashboard.`)
+	cmd.Flags().StringVar(&createReq.Dashboard.DisplayName, "display-name", createReq.Dashboard.DisplayName, `The display name of the dashboard.`)
+	cmd.Flags().StringVar(&createReq.Dashboard.SerializedDashboard, "serialized-dashboard", createReq.Dashboard.SerializedDashboard, `The contents of the dashboard in serialized string form.`)
+	cmd.Flags().StringVar(&createReq.Dashboard.WarehouseId, "warehouse-id", createReq.Dashboard.WarehouseId, `The warehouse ID used to run the dashboard.`)


Do you know why parent_path is gone?

It's marked as computed field in proto and we do not list such fields as flags anymore

github-actions · 2024-11-13T11:18:55Z

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

PR number: 1878
Commit SHA: d29f876bc822cbe77442c0078e6da96470eeb82b

Checks will be approved automatically on success.

eng-dev-ecosystem-bot · 2024-11-13T11:19:31Z

Test Details: go/deco-tests/11816191009

Bundles: * Do not execute build on bundle destroy ([#1882](#1882)). * Add support for non-Python ipynb notebooks to DABs ([#1827](#1827)). API Changes: * Added `databricks credentials` command group. * Changed `databricks genie execute-message-query` command to type `databricks genie execute-message-query` command. * Changed `databricks lakeview create` command with new required argument order. * Added `databricks aibi-dashboard-embedding-access-policy` command group. * Added `databricks aibi-dashboard-embedding-approved-domains` command group. * Removed `databricks clean-rooms` command group. OpenAPI commit d25296d2f4aa7bd6195c816fdf82e0f960f775da (2024-11-07) Dependency updates: * Upgrade TF provider to 1.58.0 ([#1900](#1900)). * Bump golang.org/x/sync from 0.8.0 to 0.9.0 ([#1892](#1892)). * Bump golang.org/x/text from 0.19.0 to 0.20.0 ([#1893](#1893)). * Bump golang.org/x/mod from 0.21.0 to 0.22.0 ([#1895](#1895)). * Bump golang.org/x/oauth2 from 0.23.0 to 0.24.0 ([#1894](#1894)). * Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0 ([#1878](#1878)).

Bundles: * Do not execute build on bundle destroy ([#1882](#1882)). * Add support for non-Python ipynb notebooks to DABs ([#1827](#1827)). API Changes: * Added `databricks credentials` command group. * Changed `databricks lakeview create` command with new required argument order. OpenAPI commit d25296d2f4aa7bd6195c816fdf82e0f960f775da (2024-11-07) Dependency updates: * Upgrade TF provider to 1.58.0 ([#1900](#1900)). * Bump golang.org/x/sync from 0.8.0 to 0.9.0 ([#1892](#1892)). * Bump golang.org/x/text from 0.19.0 to 0.20.0 ([#1893](#1893)). * Bump golang.org/x/mod from 0.21.0 to 0.22.0 ([#1895](#1895)). * Bump golang.org/x/oauth2 from 0.23.0 to 0.24.0 ([#1894](#1894)). * Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0 ([#1878](#1878)).

…1878) Known issues: - [ ] _(non-blocking with a command override)_ `apps.Update` requires 2 `name` params (one from path, one from request body) - [ ] _(non-blocking)_ `lakeview.Create` does not require positional argument `display_name` anymore because it's not marked as required in request body Bumps [github.com/databricks/databricks-sdk-go](https://github.com/databricks/databricks-sdk-go) from 0.49.0 to 0.51.0. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Nester <andrew.nester@databricks.com>

Bundles: * Do not execute build on bundle destroy ([#1882](#1882)). * Add support for non-Python ipynb notebooks to DABs ([#1827](#1827)). API Changes: * Added `databricks credentials` command group. * Changed `databricks lakeview create` command with new required argument order. OpenAPI commit d25296d2f4aa7bd6195c816fdf82e0f960f775da (2024-11-07) Dependency updates: * Upgrade TF provider to 1.58.0 ([#1900](#1900)). * Bump golang.org/x/sync from 0.8.0 to 0.9.0 ([#1892](#1892)). * Bump golang.org/x/text from 0.19.0 to 0.20.0 ([#1893](#1893)). * Bump golang.org/x/mod from 0.21.0 to 0.22.0 ([#1895](#1895)). * Bump golang.org/x/oauth2 from 0.23.0 to 0.24.0 ([#1894](#1894)). * Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0 ([#1878](#1878)).

dependabotBot added Dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 4, 2024

dependabotBottemporarily deployed to test-trigger-is November 4, 2024 11:44 Inactive

dependabotBotforce-pushed the dependabot/go_modules/github.com/databricks/databricks-sdk-go-0.50.0 branch from 57df4ac to 73f832bCompare November 4, 2024 14:46

dependabotBottemporarily deployed to test-trigger-is November 4, 2024 14:46 Inactive

regenerate + fixes
da4b856

andrewnester temporarily deployed to test-trigger-is November 4, 2024 16:19 — with GitHub Actions Inactive

andrewnester requested review from andrewnester and pietern November 4, 2024 16:20

andrewnester approved these changes Nov 4, 2024
View reviewed changes

fixed apps and dashboard command generation
91ad4df

andrewnester temporarily deployed to test-trigger-is November 8, 2024 12:37 — with GitHub Actions Inactive

Merge branch 'main' into dependabot/go_modules/github.com/databricks/…
3d96565
…databricks-sdk-go-0.50.0

andrewnester temporarily deployed to test-trigger-is November 8, 2024 13:10 — with GitHub Actions Inactive

flatten request body into params
b452f53

andrewnester temporarily deployed to test-trigger-is November 8, 2024 13:13 — with GitHub Actions Inactive

andrewnester reviewed Nov 8, 2024
View reviewed changes

andrewnester self-requested a review November 8, 2024 13:15

pietern reviewed Nov 8, 2024
View reviewed changes

Comment threadcmd/workspace/apps/apps.go Outdated
Comment threadcmd/workspace/lakeview/lakeview.go Outdated

fixes
9d193fb

andrewnester temporarily deployed to test-trigger-is November 8, 2024 15:14 — with GitHub Actions Inactive

andrewnester reviewed Nov 8, 2024
View reviewed changes

do not show computed fields
4d858dd

andrewnester changed the title ~~Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.50.0~~Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0Nov 11, 2024

andrewnester temporarily deployed to test-trigger-is November 11, 2024 16:25 — with GitHub Actions Inactive

databricks deleted a comment from dependabotBotNov 11, 2024

apps.update override + cleanup
caad1aa

andrewnester temporarily deployed to test-trigger-is November 11, 2024 16:54 — with GitHub Actions Inactive

fix test with an inline enum
87867c2

andrewnester temporarily deployed to test-trigger-is November 11, 2024 17:17 — with GitHub Actions Inactive

andrewnester removed the do-not-merge label Nov 11, 2024

pietern approved these changes Nov 13, 2024
View reviewed changes

fixed command
d29f876

andrewnester temporarily deployed to test-trigger-is November 13, 2024 11:18 — with GitHub Actions Inactive

andrewnester temporarily deployed to test-trigger-is November 13, 2024 11:19 — with GitHub Actions Inactive

andrewnester enabled auto-merge November 13, 2024 11:57

andrewnester disabled auto-merge November 13, 2024 13:04

andrewnester approved these changes Nov 13, 2024
View reviewed changes

andrewnester enabled auto-merge November 13, 2024 13:05

andrewnester disabled auto-merge November 13, 2024 13:14

andrewnester added this pull request to the merge queue Nov 13, 2024

Merged via the queue into main with commit 25838eeNov 13, 2024

andrewnester deleted the dependabot/go_modules/github.com/databricks/databricks-sdk-go-0.50.0 branch November 13, 2024 13:48

andrewnester mentioned this pull request Nov 14, 2024
[Release] Release v0.234.0 #1902
Merged

Navigation Menu

Uh oh!

Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0 - #1878

Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0#1878
andrewnester merged 12 commits into
mainfrom
dependabot/go_modules/github.com/databricks/databricks-sdk-go-0.50.0

dependabotBot commented on behalf of githubNov 4, 2024•
edited by pietern
Loading

Uh oh!

andrewnester commented Nov 4, 2024

Uh oh!

andrewnesterNov 8, 2024

Uh oh!

andrewnesterNov 11, 2024

Uh oh!

Uh oh!

Uh oh!

andrewnesterNov 8, 2024•
edited
Loading

Uh oh!

andrewnesterNov 11, 2024

Uh oh!

pieternNov 13, 2024

Uh oh!

andrewnesterNov 13, 2024

Uh oh!

github-actionsBot commented Nov 13, 2024

Uh oh!

eng-dev-ecosystem-bot commented Nov 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

dependabotBot commented on behalf of githubNov 4, 2024• edited by pietern Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewnester commented Nov 4, 2024

Uh oh!

andrewnesterNov 8, 2024

Choose a reason for hiding this comment

Uh oh!

andrewnesterNov 11, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

andrewnesterNov 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andrewnesterNov 11, 2024

Choose a reason for hiding this comment

Uh oh!

pieternNov 13, 2024

Choose a reason for hiding this comment

Uh oh!

andrewnesterNov 13, 2024

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Nov 13, 2024

Uh oh!

eng-dev-ecosystem-bot commented Nov 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dependabotBot commented on behalf of githubNov 4, 2024•
edited by pietern
Loading

andrewnesterNov 8, 2024•
edited
Loading