Uh oh!
There was an error while loading. Please reload this page.
Clean host URL in the auth login command - #1879
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pietern
left a comment
There was a problem hiding this comment.
The path was not needed after all?
Uh oh!
There was an error while loading. Please reload this page.
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
eng-dev-ecosystem-bot
commented
Nov 5, 2024
Test Details: go/deco-tests/11687272053 |
@pietern Yeah, it's not. Both account and workspace authentication work without paths. In both cases the account_id or the workspace_id is a query arg in the browser URL. Example: |
CLI: * Clean host URL in the `auth login` command ([#1879](#1879)). Bundles: * Fix bundle run when run interactively ([#1880](#1880)). * Fix relative path resolution for dashboards on Windows ([#1881](#1881)). Internal: * Address goreleaser deprecation warning ([#1872](#1872)). * Update actions/github-script to v7 ([#1873](#1873)). * Use Go 1.23 ([#1871](#1871)). * [Internal] Always write message for manual integration test trigger ([#1874](#1874)). * Add `cmd-exec-id` to user agent ([#1808](#1808)). * Added E2E test to run Python wheels on interactive cluster created in bundle ([#1864](#1864)). Dependency updates: * Bump github.com/hashicorp/terraform-json from 0.22.1 to 0.23.0 ([#1877](#1877)).
CLI: * Clean host URL in the `auth login` command ([#1879](#1879)). Bundles: * Fix bundle run when run interactively ([#1880](#1880)). * Fix relative path resolution for dashboards on Windows ([#1881](#1881)). Internal: * Address goreleaser deprecation warning ([#1872](#1872)). * Update actions/github-script to v7 ([#1873](#1873)). * Use Go 1.23 ([#1871](#1871)). * [Internal] Always write message for manual integration test trigger ([#1874](#1874)). * Add `cmd-exec-id` to user agent ([#1808](#1808)). * Added E2E test to run Python wheels on interactive cluster created in bundle ([#1864](#1864)). Dependency updates: * Bump github.com/hashicorp/terraform-json from 0.22.1 to 0.23.0 ([#1877](#1877)).
## Changes The host URL for databricks workspaces includes the workspaceId by default as a positional arg. Eg: https://e2-dogfood.staging.cloud.databricks.com/?o=1234 Thus a user can't simply copy paste the URL today to the auth login command. They'll see a runtime error: ``` ➜ cli git:(main) ✗ databricks auth login --host https://e2-dogfood.staging.cloud.databricks.com/\?o\=xxx --profile new-dg Error: oidc: fetch .well-known: failed to unmarshal response body: invalid character '<' looking for beginning of value. This is likely a bug in the Databricks SDK for Go or the underlying REST API. Please report this issue with the following debugging information to the SDK issue tracker at https://github.com/databricks/databricks-sdk-go/issues. Request log: GET /login.html ... ``` ## Tests Unit tests and manually. Now auth login works even when the workspace_id is included in the URL.
CLI: * Clean host URL in the `auth login` command ([#1879](#1879)). Bundles: * Fix bundle run when run interactively ([#1880](#1880)). * Fix relative path resolution for dashboards on Windows ([#1881](#1881)). Internal: * Address goreleaser deprecation warning ([#1872](#1872)). * Update actions/github-script to v7 ([#1873](#1873)). * Use Go 1.23 ([#1871](#1871)). * [Internal] Always write message for manual integration test trigger ([#1874](#1874)). * Add `cmd-exec-id` to user agent ([#1808](#1808)). * Added E2E test to run Python wheels on interactive cluster created in bundle ([#1864](#1864)). Dependency updates: * Bump github.com/hashicorp/terraform-json from 0.22.1 to 0.23.0 ([#1877](#1877)).
Changes
The host URL for databricks workspaces includes the workspaceId by default as a positional arg. Eg: https://e2-dogfood.staging.cloud.databricks.com/?o=1234
Thus a user can't simply copy paste the URL today to the auth login command. They'll see a runtime error:
Tests
Unit tests and manually. Now auth login works even when the workspace_id is included in the URL.