Uh oh!
There was an error while loading. Please reload this page.
Extend "notebook not found" error to warn about missing extension - #1920
Merged
Conversation
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 20, 2024 16:59 — with 
GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 20, 2024 16:59 — with GitHub Actions
Inactive
shreyas-goenka
marked this pull request as ready for review
November 20, 2024 17:10
pietern
reviewed
Nov 20, 2024
pietern
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks. One suggestion in the comments.
Uh oh!
There was an error while loading. Please reload this page.
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 20, 2024 23:43 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 20, 2024 23:43 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 20, 2024 23:49 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 20, 2024 23:49 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 21, 2024 00:03 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 21, 2024 00:03 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 21, 2024 00:04 — with GitHub Actions
Inactive
Contributor
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 21, 2024 00:04 — with GitHub Actions
Inactive
eng-dev-ecosystem-bot
commented
Nov 21, 2024
Collaborator
Test Details: go/deco-tests/11943918301 |
pietern
approved these changes
Nov 21, 2024
pietern
left a comment
Contributor
There was a problem hiding this comment.
Thanks, LGTM!
Please update the PR description to include the "did you mean" bit before merging.
pietern added a commit
that referenced
this pull request
Dec 5, 2024
**New features for Databricks Asset Bundles:** This release adds support for managing Unity Catalog volumes as part of your bundle configuration. Bundles: * Add DABs support for Unity Catalog volumes ([#1762](#1762)). * Support lookup by name of notification destinations ([#1922](#1922)). * Extend "notebook not found" error to warn about missing extension ([#1920](#1920)). * Skip sync warning if no sync paths are defined ([#1926](#1926)). * Add validation for single node clusters ([#1909](#1909)). * Fix segfault in bundle summary command ([#1937](#1937)). * Add the `bundle_uuid` helper function for templates ([#1947](#1947)). * Add default value for `volume_type` for DABs ([#1952](#1952)). * Properly read Git metadata when running inside workspace ([#1945](#1945)). * Upgrade TF provider to 1.59.0 ([#1960](#1960)). Internal: * Breakout variable lookup into separate files and tests ([#1921](#1921)). * Add golangci-lint v1.62.2 ([#1953](#1953)). Dependency updates: * Bump golang.org/x/term from 0.25.0 to 0.26.0 ([#1907](#1907)). * Bump github.com/Masterminds/semver/v3 from 3.3.0 to 3.3.1 ([#1930](#1930)). * Bump github.com/stretchr/testify from 1.9.0 to 1.10.0 ([#1932](#1932)). * Bump github.com/databricks/databricks-sdk-go from 0.51.0 to 0.52.0 ([#1931](#1931)).
github-merge-queueBot
pushed a commit
that referenced
this pull request
Dec 5, 2024
**New features for Databricks Asset Bundles:** This release adds support for managing Unity Catalog volumes as part of your bundle configuration. Bundles: * Add DABs support for Unity Catalog volumes ([#1762](#1762)). * Support lookup by name of notification destinations ([#1922](#1922)). * Extend "notebook not found" error to warn about missing extension ([#1920](#1920)). * Skip sync warning if no sync paths are defined ([#1926](#1926)). * Add validation for single node clusters ([#1909](#1909)). * Fix segfault in bundle summary command ([#1937](#1937)). * Add the `bundle_uuid` helper function for templates ([#1947](#1947)). * Add default value for `volume_type` for DABs ([#1952](#1952)). * Properly read Git metadata when running inside workspace ([#1945](#1945)). * Upgrade TF provider to 1.59.0 ([#1960](#1960)). Internal: * Breakout variable lookup into separate files and tests ([#1921](#1921)). * Add golangci-lint v1.62.2 ([#1953](#1953)). Dependency updates: * Bump golang.org/x/term from 0.25.0 to 0.26.0 ([#1907](#1907)). * Bump github.com/Masterminds/semver/v3 from 3.3.0 to 3.3.1 ([#1930](#1930)). * Bump github.com/stretchr/testify from 1.9.0 to 1.10.0 ([#1932](#1932)). * Bump github.com/databricks/databricks-sdk-go from 0.51.0 to 0.52.0 ([#1931](#1931)).
denik pushed a commit
that referenced
this pull request
May 20, 2026
) ## Changes The full workspace path for a notebook does not contain the notebook's extension. If a user converts that file path to a relative path (like `/Workspace/bundle_root/bar/nb` -> `./bar/nb`), they can be confused as to why the new file path does not work. The changes in this PR nudge them to add the appropriate file extension (e.g., `./bar/nb.py` or `./bar/nb.ipynb`). One common way users can end up in this scenario is by using the view job as YAML functionality in the Databricks UI. ## Tests Unit test and manually. ``` (.venv) ➜ bundle-playground git:(master) ✗ cli bundle validate Error: notebook ./foo not found. Local notebook references are expected to contain one of the following file extensions: [.py, .r, .scala, .sql, .ipynb] ```
denik pushed a commit
that referenced
this pull request
May 20, 2026
**New features for Databricks Asset Bundles:** This release adds support for managing Unity Catalog volumes as part of your bundle configuration. Bundles: * Add DABs support for Unity Catalog volumes ([#1762](#1762)). * Support lookup by name of notification destinations ([#1922](#1922)). * Extend "notebook not found" error to warn about missing extension ([#1920](#1920)). * Skip sync warning if no sync paths are defined ([#1926](#1926)). * Add validation for single node clusters ([#1909](#1909)). * Fix segfault in bundle summary command ([#1937](#1937)). * Add the `bundle_uuid` helper function for templates ([#1947](#1947)). * Add default value for `volume_type` for DABs ([#1952](#1952)). * Properly read Git metadata when running inside workspace ([#1945](#1945)). * Upgrade TF provider to 1.59.0 ([#1960](#1960)). Internal: * Breakout variable lookup into separate files and tests ([#1921](#1921)). * Add golangci-lint v1.62.2 ([#1953](#1953)). Dependency updates: * Bump golang.org/x/term from 0.25.0 to 0.26.0 ([#1907](#1907)). * Bump github.com/Masterminds/semver/v3 from 3.3.0 to 3.3.1 ([#1930](#1930)). * Bump github.com/stretchr/testify from 1.9.0 to 1.10.0 ([#1932](#1932)). * Bump github.com/databricks/databricks-sdk-go from 0.51.0 to 0.52.0 ([#1931](#1931)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The full workspace path for a notebook does not contain the notebook's extension. If a user converts that file path to a relative path (like
/Workspace/bundle_root/bar/nb->./bar/nb), they can be confused as to why the new file path does not work.The changes in this PR nudge them to add the appropriate file extension (e.g.,
./bar/nb.pyor./bar/nb.ipynb). WeOne common way users can end up in this scenario is by using the view job as YAML functionality in the Databricks UI.
Tests
Unit test and manually.
When we detect that a candidate file exists then the error message is more targeted: