Skip to content

Upgrade TF provider to 1.61.0 - #2011

Merged
andrewnester merged 3 commits into
mainfrom
tf-provider-1.61.0
Dec 13, 2024
Merged

Upgrade TF provider to 1.61.0#2011
andrewnester merged 3 commits into
mainfrom
tf-provider-1.61.0

Conversation

@andrewnester

@andrewnesterandrewnester commented Dec 13, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

Upgraded to TF provider 1.61.0

New Features and Improvements

andrewnester
andrewnester commented Dec 13, 2024
View reviewed changes
Comment threadbundle/internal/tf/codegen/generator/walker.go Outdated
pietern
pietern reviewed Dec 13, 2024
View reviewed changes
Comment threadbundle/internal/tf/schema/resource_quality_monitor.go Outdated
Comment threadbundle/internal/tf/schema/resource_app.go Outdated
pietern
pietern reviewed Dec 13, 2024
View reviewed changes

@pieternpietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also include a short summary of the changes in the PR.

Did you confirm the apps PR works with this one?

Comment threadbundle/internal/tf/codegen/generator/walker.go Outdated
Comment threadbundle/internal/tf/schema/root.go Outdated
mgyucht
mgyucht reviewed Dec 13, 2024
View reviewed changes

@mgyuchtmgyucht left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, but I would defer to @pietern.

@github-actions

github-actionsBot commented Dec 13, 2024

Copy link
Copy Markdown
Contributor

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 2011
  • Commit SHA: 2300a5755ed64498a3a556a45196cdb53c1e9732

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Dec 13, 2024

Copy link
Copy Markdown
Collaborator

Test Details: go/deco-tests/12317381321

@andrewnester

andrewnester commented Dec 13, 2024

Copy link
Copy Markdown
ContributorAuthor

@pietern confirmed it works, just needed to remove the resources -> resource rename when doing TF conversion

@pieternpietern changed the title Upgraded to TF provider 1.61.0Upgrade TF provider to 1.61.0Dec 13, 2024
pietern
pietern approved these changes Dec 13, 2024
View reviewed changes

@pieternpietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you update the PR summary before merging?

@andrewnester
andrewnester added this pull request to the merge queueDec 13, 2024
Merged via the queue into main with commit 58dfa70Dec 13, 2024
@andrewnester
andrewnester deleted the tf-provider-1.61.0 branch December 13, 2024 16:01
denik pushed a commit that referenced this pull request May 20, 2026
@andrewnester
Upgrade TF provider to 1.61.0 (#2011)
51b6bd3
## Changes
Upgraded to TF provider 1.61.0
### New Features and Improvements
- Added databricks_app resource and data source
(databricks/terraform-provider-databricks#4099).
- Added databricks_credentials resource and data source
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pieternpieternpietern approved these changes
@denikdenikAwaiting requested review from denik
@shreyas-goenkashreyas-goenkaAwaiting requested review from shreyas-goenka
+1 more reviewer
@mgyuchtmgyuchtmgyucht left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewnester@eng-dev-ecosystem-bot@pietern@mgyucht