Uh oh!
There was an error while loading. Please reload this page.
fix: Empty schema fields in OpenAPI spec - #2045
Merged
Merged
Conversation
ilyakuz-dbtemporarily deployed
to
test-trigger-is
December 23, 2024 09:39 — with 
GitHub Actions
Inactive
ilyakuz-dbtemporarily deployed
to
test-trigger-is
December 23, 2024 09:39 — with GitHub Actions
Inactive
ilyakuz-dbtemporarily deployed
to
test-trigger-is
December 23, 2024 10:32 — with GitHub Actions
Inactive
ilyakuz-dbtemporarily deployed
to
test-trigger-is
December 23, 2024 10:32 — with GitHub Actions
Inactive
ilyakuz-dbtemporarily deployed
to
test-trigger-is
December 23, 2024 10:38 — with GitHub Actions
Inactive
Contributor
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
ilyakuz-dbtemporarily deployed
to
test-trigger-is
December 23, 2024 10:39 — with GitHub Actions
Inactive
andrewnester
approved these changes
Dec 23, 2024
pietern added a commit
that referenced
this pull request
Jan 8, 2025
Bundles: * Fix finding Python within virtualenv on Windows ([#2034](#2034)). * Include missing field descriptions in JSON schema ([#2045](#2045)). * Add validation for volume referenced from `artifact_path` ([#2050](#2050)). * Handle `${workspace.file_path}` references in source-linked deployments ([#2046](#2046)). * Set the write bit for files written during template initialization ([#2068](#2068)).
github-merge-queueBot
pushed a commit
that referenced
this pull request
Jan 8, 2025
Bundles: * Fix finding Python within virtualenv on Windows ([#2034](#2034)). * Include missing field descriptions in JSON schema ([#2045](#2045)). * Add validation for volume referenced from `artifact_path` ([#2050](#2050)). * Handle `${workspace.file_path}` references in source-linked deployments ([#2046](#2046)). * Set the write bit for files written during template initialization ([#2068](#2068)).
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes 1. Removes default yaml-fields during schema generation, caused by [this PR](#2032) (current yaml package can't read `json` annotations in struct fields) 2. Addresses missing annotations for fields from OpenAPI spec, which are named differently in go SDK 3. Adds filtering for annotations.yaml to include only CLI package fields 4. Implements alphabetical sort for yaml keys to avoid unnecessary diff in PRs ## Tests Manually tested
denik pushed a commit
that referenced
this pull request
May 20, 2026
Bundles: * Fix finding Python within virtualenv on Windows ([#2034](#2034)). * Include missing field descriptions in JSON schema ([#2045](#2045)). * Add validation for volume referenced from `artifact_path` ([#2050](#2050)). * Handle `${workspace.file_path}` references in source-linked deployments ([#2046](#2046)). * Set the write bit for files written during template initialization ([#2068](#2068)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
jsonannotations in struct fields)Tests
Manually tested