Uh oh!
There was an error while loading. Please reload this page.
Migrate path translation tests to acceptance tests - #2122
Merged
Conversation
pietern
marked this pull request as ready for review
January 10, 2025 17:57
pieterntemporarily deployed
to
test-trigger-is
January 10, 2025 17:57 — with 
GitHub Actions
Inactive
denik
reviewed
Jan 13, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pieterntemporarily deployed
to
test-trigger-is
January 14, 2025 08:55 — with GitHub Actions
Inactive
denik
approved these changes
Jan 14, 2025
pieterntemporarily deployed
to
test-trigger-is
January 14, 2025 17:26 — with GitHub Actions
Inactive
pieternforce-pushed
the
path-translation-acceptance-1
branch
from
January 14, 2025 17:41
01b581c to
e683c1bComparepieterntemporarily deployed
to
test-trigger-is
January 14, 2025 17:41 — with GitHub Actions
Inactive
pietern
commented
Jan 14, 2025
ContributorAuthor
Blocked on #2145. |
github-merge-queueBot
pushed a commit
that referenced
this pull request
Jan 17, 2025
## Changes This came up in #2122 where relative library paths showed up with backslashes on Windows. It's hard to run acceptance tests where paths may be in either form. This change updates path translation logic to always use forward slash-separated paths, including for absolute paths. ## Tests * Unit tests pass. * Confirmed that code where library paths are used uses the `filepath` package for path manipulation. The functions in this package always normalize their inputs to be platform-native paths. * Confirmed that code that uses absolute paths works with forward slash-separated paths on Windows.
pieterntemporarily deployed
to
test-trigger-is
January 17, 2025 09:44 — with GitHub Actions
Inactive
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes This came up in #2122 where relative library paths showed up with backslashes on Windows. It's hard to run acceptance tests where paths may be in either form. This change updates path translation logic to always use forward slash-separated paths, including for absolute paths. ## Tests * Unit tests pass. * Confirmed that code where library paths are used uses the `filepath` package for path manipulation. The functions in this package always normalize their inputs to be platform-native paths. * Confirmed that code that uses absolute paths works with forward slash-separated paths on Windows.
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes The assertions on the output made are now captured in the `output.*` files. These don't capture intent like actual assertions do, but we still have regular test coverage in the path translation tests under `bundle/config/mutator`. ## Tests Tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The assertions on the output made are now captured in the
output.*files. These don't capture intent like actual assertions do, but we still have regular test coverage in the path translation tests underbundle/config/mutator.Tests
Tests pass.