Uh oh!
There was an error while loading. Please reload this page.
Use regular expressions for testdiff replacements - #2151
Merged
Conversation
pietern
requested review from
andrewnester, denik and shreyas-goenka
as code ownersJanuary 15, 2025 10:33
pieterntemporarily deployed
to
test-trigger-is
January 15, 2025 10:33 — with 
GitHub Actions
Inactive
denik
approved these changes
Jan 15, 2025
Uh oh!
There was an error while loading. Please reload this page.
pieterntemporarily deployed
to
test-trigger-is
January 15, 2025 10:43 — with GitHub Actions
Inactive
pietern
enabled auto-merge
January 15, 2025 10:44
denik
reviewed
Jan 15, 2025
Uh oh!
There was an error while loading. Please reload this page.
pietern
commented
Jan 15, 2025
ContributorAuthor
Integration test failure is unrelated. |
pietern
disabled auto-merge
January 15, 2025 11:15
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes Replacement was split between the type `ReplacementContext` and the `ReplaceOutput` function. The latter also ran a couple of regular expressions. This change consolidates them such that it is up to the caller to compose the set of replacements to use. This change is required to accommodate UUID replacement in #2146.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Replacement was split between the type
ReplacementContextand theReplaceOutputfunction. The latter also ran a couple of regular expressions. This change consolidates them such that it is up to the caller to compose the set of replacements to use.This change is required to accommodate UUID replacement in #2146.