Uh oh!
There was an error while loading. Please reload this page.
acc: default-sql: test validate/deploy/summary locally - #2316
Closed
denik wants to merge 24 commits into
Closed
Conversation
denikforce-pushed
the
denik/acc-templates-deploy
branch
from
February 10, 2025 10:56
921acb7 to
5db063cComparedenikforce-pushed
the
denik/acc-templates-deploy
branch
from
February 10, 2025 11:44
5db063c to
0ad3474Comparedenikforce-pushed
the
denik/acc-templates-deploy
branch
from
February 10, 2025 12:41
302c5c8 to
897586bComparedenik added a commit
that referenced
this pull request
Feb 10, 2025
## Changes - Insert newline after rendering indented JSON in bundle validate/summary/run. - This prevents "No newline at end of file" message in various cases, for example when switching between recording raw output of the command to output processed by jq, since jq does add a newline or when running diff in acceptance tests. ## Tests Manually running validate: ``` ~/work/dabs_cuj_brickfood % ../cli/cli-main bundle validate -o json | tail -n 2 # without change Error: root_path must start with '~/' or contain the current username to ensure uniqueness when using 'mode: development' } }% ~/work/dabs_cuj_brickfood % ../cli/cli bundle validate -o json | tail -n 2 # with change Error: root_path must start with '~/' or contain the current username to ensure uniqueness when using 'mode: development' } } ~/work/dabs_cuj_brickfood % ``` Via #2316 -- see cleaner output there.
denikforce-pushed
the
denik/acc-templates-deploy
branch
from
February 10, 2025 22:37
e43f31e to
d0cbf0dComparedenikforce-pushed
the
denik/gorilla-mix-r1
branch
5 times, most recently
from
February 11, 2025 14:27
f23d438 to
f3a13b7Comparedenikforce-pushed
the
denik/acc-templates-deploy
branch
from
February 12, 2025 10:42
0c0eb10 to
739833dCompare…ody bug Handlers now receive testserver.Request and return any which could be - nil (returns 404) - string / []byte (returns it as is but sets content-type to json or test depending on content) - object (encodes it as json and sets content-type to json) - testserver.Response (full control over status, headers) The config is now using the same testserver.Response struct as handlers, so the same logic applies there. It is now possible to specify headers in test.toml. This also fixes a bug with RecordRequest reading the body, not leaving it for the actual handler.
--- bundle\templates\default-sql\out.validate.prod.json +++ C:\Users\RUNNER~1\AppData\Local\Temp\TestAcceptbundletemplatesdefault-sql3270131331\001\out.validate.prod.json @@ -13,7 +13,7 @@ "uuid": "[UUID]" }, "include": [ - "resources/my_default_sql_sql.job.yml" + "resources\\my_default_sql_sql.job.yml"
denikforce-pushed
the
denik/acc-templates-deploy
branch
from
February 12, 2025 11:55
1475924 to
3b19b69CompareContributor
This PR has not received an update in a while. If you want to keep this PR open, please leave a comment below or push a new commit and auto-close will be canceled. |
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes - Insert newline after rendering indented JSON in bundle validate/summary/run. - This prevents "No newline at end of file" message in various cases, for example when switching between recording raw output of the command to output processed by jq, since jq does add a newline or when running diff in acceptance tests. ## Tests Manually running validate: ``` ~/work/dabs_cuj_brickfood % ../cli/cli-main bundle validate -o json | tail -n 2 # without change Error: root_path must start with '~/' or contain the current username to ensure uniqueness when using 'mode: development' } }% ~/work/dabs_cuj_brickfood % ../cli/cli bundle validate -o json | tail -n 2 # with change Error: root_path must start with '~/' or contain the current username to ensure uniqueness when using 'mode: development' } } ~/work/dabs_cuj_brickfood % ``` Via #2316 -- see cleaner output there.
denik added a commit
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.