Uh oh!
There was an error while loading. Please reload this page.
acc: add Ignore setting to config - #2405
Merged
Merged
Conversation
Ignore output files using gitignore syntax. I'm using it in #2396 to ignore virtual env. It includes a lot of files. The regular 'rm -fr .venv' approach only works if scripts get to that point. However, if there are any errors, it does not, and outputs a lot of files, polluting output. Ignoring those files at test runner level ensure you never see them.
denik
requested review from
andrewnester, pietern and shreyas-goenka
as code ownersFebruary 28, 2025 13:53
denik
enabled auto-merge
February 28, 2025 13:53
shreyas-goenka
approved these changes
Feb 28, 2025
denik added a commit
that referenced
this pull request
May 20, 2026
Ignore output files using gitignore syntax. ## Changes New Ignore setting in test.toml that will ignore specified files (syntax is gitignore). ## Why I'm using it in #2396 to ignore virtual env. It includes a lot of files. The regular 'rm -fr .venv' approach only works if script get to that point, but due to errors it might abort early. In that cases test runner prints all unexpected files, polluting output. Ignoring those files at test runner level ensure you never see them. ## Tests Updated selftest/basic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore output files using gitignore syntax.
Changes
New Ignore setting in test.toml that will ignore specified files (syntax is gitignore).
Why
I'm using it in #2396 to ignore virtual env. It includes a lot of files. The regular 'rm -fr .venv' approach only works if script get to that point, but due to errors it might abort early. In that cases test runner prints all unexpected files, polluting output. Ignoring those files at test runner level ensure you never see them.
Tests
Updated selftest/basic.