Uh oh!
There was an error while loading. Please reload this page.
acc: Automatically rename .gitignore -> out.gitignore - #2428
Closed
denik wants to merge 1 commit into
Closed
Conversation
to avoid manually renaming it in every test. Note, there is still a use case where renaming in 'script' is needed: when using diff.py to compare results with other pre-recorded output. In that case, local directory is not yet processed by test runner, so mv is still need.
denik
requested review from
andrewnester, pietern and shreyas-goenka
as code ownersMarch 4, 2025 16:12
denik
marked this pull request as draft
March 5, 2025 07:48
ContributorAuthor
Decided not to complicate test runner for this and keep this inside 'script'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Acceptance test runner will now automatically rename .gitignore to out.gitignore whenever it sees them.
Why
This to avoid manually renaming it in every test. We never want .gitignore in our tests that are related to tests and not cli repo itself.
Note, there is still a use case where renaming in 'script' is needed: when using diff.py to compare results with other pre-recorded output. In that case, local directory is not yet processed by test runner, so mv is still need.
Tests
Using this in #2429