Uh oh!
There was an error while loading. Please reload this page.
Fix patchwheel.ParseWheelFilename to extract basename - #2521
Merged
Conversation
denik
requested review from
andrewnester, pietern and shreyas-goenka
as code ownersMarch 19, 2025 11:12
denik
enabled auto-merge
March 19, 2025 11:13
This makes it easier to use.
denikforce-pushed
the
denik/acc-parse-wheel-base
branch
from
March 19, 2025 11:21
8c8f6e6 to
3f86ef5Compare| // The function does not try hard to validate if the format is correct, it tries to parse whatever is available. | ||
| // However, it does require 5 or 6 components in the filename. | ||
| func ParseWheelFilename(filename string) (WheelInfo, error) { | ||
| filename = path.Base(filename) |
Contributor
There was a problem hiding this comment.
Shouldn't it be filepath.Base to be OS specific?
Contributor
There was a problem hiding this comment.
You need to use filepath.Base on Windows unless you know the path is slash-separated.
pietern
reviewed
Mar 19, 2025
| require.Equal(t, tt.wantTags, info.Tags, "tags mismatch") | ||
| } | ||
| }) | ||
| for _, prefix := range prefixes { |
Contributor
There was a problem hiding this comment.
Double nesting is not really needed here. Can you add one additional case to the table?
| // The function does not try hard to validate if the format is correct, it tries to parse whatever is available. | ||
| // However, it does require 5 or 6 components in the filename. | ||
| func ParseWheelFilename(filename string) (WheelInfo, error) { | ||
| filename = path.Base(filename) |
Contributor
There was a problem hiding this comment.
You need to use filepath.Base on Windows unless you know the path is slash-separated.
andrewnester
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is a minor change but makes it easier to use, no need to remember doing this on the caller side.
Relying on this in #2520
Follow up to #2427
Tests
New unit tests.