Skip to content

Print relative path to uploaded artifact and with deterministic order - #2539

Merged
denik merged 6 commits into
mainfrom
denik/artifacts-upload-determ
Mar 20, 2025
Merged

Print relative path to uploaded artifact and with deterministic order#2539
denik merged 6 commits into
mainfrom
denik/artifacts-upload-determ

Conversation

@denik

@denikdenik commented Mar 20, 2025

Copy link
Copy Markdown
Contributor

Changes

  • When printing "Uploading name.whl..." message, include path relative to sync root in name. Previously it only included filename. The path separator is always forward slash.
  • Print those messages in deterministic order.

Why

Mainly to simplify and get more value from acceptance tests, especially those where multiple wheels are involved.
Printing relative path also gives user better idea of what's going on.

Tests

Updated tests where we had to work around lack of determinism.

@denik
denikforce-pushed the denik/artifacts-upload-determ branch from eb7403e to e486c45CompareMarch 20, 2025 13:54
@denik
deniktemporarily deployed to test-trigger-is March 20, 2025 13:54 — with GitHub Actions Inactive
@denikdenik changed the title Denik/artifacts upload determPrint relative path to uploaded artifact and with deterministic orderMar 20, 2025
@denik
denik enabled auto-merge March 20, 2025 14:00
@denik
deniktemporarily deployed to test-trigger-is March 20, 2025 14:08 — with GitHub Actions Inactive
@denik
deniktemporarily deployed to test-trigger-is March 20, 2025 14:43 — with GitHub Actions Inactive
@denik
denik added this pull request to the merge queueMar 20, 2025
Merged via the queue into main with commit adfc75eMar 20, 2025
@denik
denik deleted the denik/artifacts-upload-determ branch March 20, 2025 15:12
denik added a commit that referenced this pull request Mar 20, 2025
Follow up to #2539
Since these are "slow" tests, PR checks did not catch them.
@denikdenik mentioned this pull request Mar 20, 2025
github-merge-queueBot pushed a commit that referenced this pull request Mar 21, 2025
Follow up to #2539
Since these are "slow" tests, PR checks did not catch them.
deco-sdk-taggingBot added a commit that referenced this pull request Mar 26, 2025
## Release v0.245.0
### Bundles
* Processing 'artifacts' section is now done in "bundle validate" (adding defaults, inferring "build", asserting required fields) ([#2526])(#2526))
* When uploading artifacts, include relative path in log message ([#2539])(#2539))
* Added support for clusters in deployment bind/unbind commands ([#2536](#2536))
* Added support for volumes in deployment bind/unbind commands ([#2527](#2527))
* Added support for dashboards in deployment bind/unbind commands ([#2516](#2516))
* Added support for registered models in deployment bind/unbind commands ([#2556](#2556))
* Added a mismatch check when host is defined in config and as an env variable ([#2549](#2549))
* New attribute on artifacts entries: `dynamic_version`. When set to true, it patches the wheel with dynamic version suffix so it is always used by Databricks environments, even if original wheel version is the same. Intended for development loop on interactive clusters. ([#2520](#2520))
denik added a commit that referenced this pull request May 20, 2026
…#2539)
## Changes
- When printing "Uploading name.whl..." message, include path relative
to sync root in name. Previously it only included filename. The path
separator is always forward slash.
- Print those messages in deterministic order.
## Why
Mainly to simplify and get more value from acceptance tests, especially
those where multiple wheels are involved.
Printing relative path also gives user better idea of what's going on.
## Tests
Updated tests where we had to work around lack of determinism.
denik added a commit that referenced this pull request May 20, 2026
Follow up to #2539
Since these are "slow" tests, PR checks did not catch them.
denik pushed a commit that referenced this pull request May 20, 2026
## Release v0.245.0
### Bundles
* Processing 'artifacts' section is now done in "bundle validate" (adding defaults, inferring "build", asserting required fields) ([#2526])(#2526))
* When uploading artifacts, include relative path in log message ([#2539])(#2539))
* Added support for clusters in deployment bind/unbind commands ([#2536](#2536))
* Added support for volumes in deployment bind/unbind commands ([#2527](#2527))
* Added support for dashboards in deployment bind/unbind commands ([#2516](#2516))
* Added support for registered models in deployment bind/unbind commands ([#2556](#2556))
* Added a mismatch check when host is defined in config and as an env variable ([#2549](#2549))
* New attribute on artifacts entries: `dynamic_version`. When set to true, it patches the wheel with dynamic version suffix so it is always used by Databricks environments, even if original wheel version is the same. Intended for development loop on interactive clusters. ([#2520](#2520))
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@denik@andrewnester