Uh oh!
There was an error while loading. Please reload this page.
dyn: Use nil as default location instead of empty slice - #2742
Merged
Conversation
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersApril 22, 2025 07:58
pietern
commented
Apr 22, 2025
Contributor
Is this complete? Could we enforce no use of |
| func TestMappingKeysValues(t *testing.T) { | ||
| // Configure mapping | ||
| var m dyn.Mapping | ||
| m.SetLoc("key1", []dyn.Location{}, dyn.V("foo")) |
Contributor
There was a problem hiding this comment.
There are other places in the code where we use []dyn.Location{}, should it be changed as well?
denik
commented
Apr 22, 2025
ContributorAuthor
I updated more places as returned by Regarding linter, maybe we can adapt #2576 cc @anton-107 but I'd say it's out of scope here. Once we get rid of dynassert, various test cases that currently ignore location would require exact location there, so it's not something that's untested. |
andrewnester
approved these changes
Apr 22, 2025
denik added a commit
that referenced
this pull request
May 20, 2026
## Why - This starts to matter once we replace dynassert with regular assert #2737 - We agreed before to use nils consistently instead of empty slices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why