Uh oh!
There was an error while loading. Please reload this page.
Fix nil crash when job has no fields defined - #2776
Merged
Merged
Conversation
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersApril 25, 2025 10:30
andrewnester
approved these changes
Apr 25, 2025
denik
commented
Apr 25, 2025
ContributorAuthor
This PR is stacked on #2774 please review that one as well. |
pietern
approved these changes
Apr 25, 2025
denik
enabled auto-merge
April 25, 2025 11:31
denik
disabled auto-merge
April 25, 2025 11:40
This was referenced May 2, 2025
denik added a commit
that referenced
this pull request
May 8, 2025
## Changes - Embed struct by value not by pointer in all the resources. - Remove IsNil method from the resource interface and implementations (it's never true). ## Why - Prevents a class of crashes related to nil pointer, like #2776 and #1937 - Simplify user code, no need to check nilness as much. ## Tests Existing tests.
denik added a commit
that referenced
this pull request
May 20, 2026
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes - Embed struct by value not by pointer in all the resources. - Remove IsNil method from the resource interface and implementations (it's never true). ## Why - Prevents a class of crashes related to nil pointer, like #2776 and #1937 - Simplify user code, no need to check nilness as much. ## Tests Existing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add missing nil checks in normalize_paths.go
Tests
Tests added previously in #2771 and #2774