Uh oh!
There was an error while loading. Please reload this page.
Sort file names in sync events before the events are emitted - #2833
Closed
anton-107 wants to merge 1 commit into
Closed
Sort file names in sync events before the events are emitted#2833anton-107 wants to merge 1 commit into
anton-107 wants to merge 1 commit into
Conversation
anton-107
marked this pull request as ready for review
May 8, 2025 10:53
anton-107
requested review from
andrewnester, denik, pietern and shreyas-goenka
as code ownersMay 8, 2025 10:53
anton-107
marked this pull request as draft
May 8, 2025 11:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In #2824 sorting was added on event read, which caused the slices to be mutated and changed the order of the sync operations.
In
Tests
Existing acceptance test run with hyperfine
was consistently failing on 20-30th iteration before this change and is not failing on 100 iterations after the change.