Skip to content

Always use line feed for newlines in acceptance tests#2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreyas-goenka merged 5 commits into from
May 19, 2025
Merged

Always use line feed for newlines in acceptance tests #2865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ae2852
Always use line feed for newlines in acceptance tests
shreyas-goenka May 13, 2025
a923117
-
shreyas-goenka May 13, 2025
e741e75
-
shreyas-goenka May 13, 2025
aec3252
Merge remote-tracking branch 'origin' into lf-gitattibute
shreyas-goenka May 16, 2025
a2039fe
address comemnts
shreyas-goenka May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions acceptance/.gitattributes
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
# We should always treat new lines in text files acceptance tests in windows as \n.
# This is important because the characters itself can be semantically important in tests.
# For example, an additional \r character in windows changes the upload payload if you are
# uploading the file's content to a workspace.
*.txt text eol=lf
7 changes: 1 addition & 6 deletions acceptance/selftest/record_cloud/workspace-file-io/test.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
# hello, world\n base64 encoded in unix
# hello, world\n base64 encoded
[[Repls]]
Old = "aGVsbG8sIHdvcmxkCg=="
New = "[HELLO-WORLD]"

@denikdenikMay 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not drop this replacement as well? It's not dynamic, so a comment in the script will do.

@shreyas-goenkashreyas-goenkaMay 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's slightly more robust. A comment would be easy to miss if the actual uploaded value changes. People might miss a base64 encoding change if, for example, someone decides to refactor the test.

It's also what we do for base64 encoded strings in other places.

I don't mind either way though, happy to go with a comment too.

@denikdenikMay 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, the less replacements there are, the easier it is to read the test output.


# hello, world\n base64 encoded in windows
[[Repls]]
Old = "aGVsbG8sIHdvcmxkDQo="
New = "[HELLO-WORLD]"