Uh oh!
There was an error while loading. Please reload this page.
Inline execution of commands in shell - #2885
Closed
shreyas-goenka wants to merge 19 commits into
Closed
Conversation
shreyas-goenkatemporarily deployed
to
test-trigger-is
May 14, 2025 14:21 — with 
GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
May 14, 2025 14:35 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
May 14, 2025 15:00 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
May 14, 2025 15:01 — with GitHub Actions
Inactive
shreyas-goenka
marked this pull request as ready for review
May 14, 2025 15:21
shreyas-goenka
requested review from
andrewnester, anton-107, denik and pietern
as code ownersMay 14, 2025 15:21
shreyas-goenkatemporarily deployed
to
test-trigger-is
May 15, 2025 07:46 — with GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR changes the way artifact build scripts are executed by having them execute inline instead of writing a temporary script.
Why
Prompted by #2862 (comment). Inlining the content of the script gets rid of the temporary file altogether. This is nice because in windows temporary files are not automatically cleaned up.
Note: There is a small regression here. Passing the script via stdin and executing via call are not completely identical. For example, if the program involves GOTO statements that'll stop working as expected:
Tests
Existing acceptance tests.