Uh oh!
There was an error while loading. Please reload this page.
Remove the integration test TestDeployBasicBundleLogs - #2907
Merged
Conversation
anton-107
marked this pull request as ready for review
May 19, 2025 14:45
anton-107
requested review from
andrewnester, denik, pietern and shreyas-goenka
as code ownersMay 19, 2025 14:45
denik
approved these changes
May 19, 2025
pietern
commented
May 20, 2025
Contributor
Happy to see this cleaned up. Great find. |
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> Remove a regression test introduced in #1711. This test aimed to capture leaked logs to stderr. This test is obsolete with the new style of acceptance tests, which compares the binary output with the golden file - these existing tests will capture this kind of regression. ## Tests Added an unconditional output line to stderr and confirmed that acceptance tests capture it and fail the suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Remove a regression test introduced in #1711. This test aimed to capture leaked logs to stderr. This test is obsolete with the new style of acceptance tests, which compares the binary output with the golden file - these existing tests will capture this kind of regression.
Tests
Added an unconditional output line to stderr and confirmed that acceptance tests capture it and fail the suite.